Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP constraints to allow v8.3 #176

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Update PHP constraints to allow v8.3 #176

merged 1 commit into from
Oct 29, 2023

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Oct 27, 2023

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC yes
QA no

Description

Refs #175

@ADmad
Copy link
Contributor Author

ADmad commented Oct 27, 2023

The "QA Checks' failure seems to be due to a bug in psalm which is addressed here vimeo/psalm#10186 but hasn't been released yet.

Ocramius
Ocramius requested changes Oct 29, 2023
View reviewed changes
composer.lock Outdated Show resolved Hide resolved
@Ocramius Ocramius added this to the 2.26.0 milestone Oct 29, 2023
@Ocramius Ocramius assigned Ocramius and unassigned ADmad Oct 29, 2023
Ocramius
Ocramius approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ADmad!

@Ocramius Ocramius merged commit 6584d44 into laminas:2.26.x Oct 29, 2023
13 checks passed
@ADmad
Copy link
Contributor Author

ADmad commented Oct 29, 2023

I reverted the changes and then ran compose update --lock, not sure why it downgraded the version for plugin-api-version.

@github-actions github-actions bot mentioned this pull request Oct 29, 2023
Merged
@ADmad
Copy link
Contributor Author

ADmad commented Oct 29, 2023

I reverted the changes and then ran compose update --lock, not sure why it downgraded the version for plugin-api-version.

TIL: The value for plugin-api-version in composer.lock depends on the composer version used. I had used an older 2.0.4 version of composer hence plugin-api-version was set to 2.0.0.

@gsteel gsteel mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ADmad @Ocramius