-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x series does not support PHP 8.3 #175
Comments
I don't think Can we perhaps help there instead, if there are any blockers? |
What do you mean with "bad way of constraining"? |
From your upstream issue:
This is what I'd suggest widening to |
See #117 It is a past (and present) disagreement from the issue author with our approach to dependency management, which we explained in depth to be well founded, well intended, and I assume well understood now. |
BTW, we use |
cakephp/cakephp#17388 shows that this is not possible.
I am sure tons of other libraries will run into the same issue sooner or later, so this is not about reviving, but providing
This will not help in this case for all the libraries, as the constraint is still blocking it beyond the time schedule of stable release of 8.3 - and it creates other side effects as pulling invalid other dependencies that can create noise and make it harder to determine the actual compatibility in regards to this library and PHP 8.3 alone. |
@dereuromark it looks like the problem is not with this library, but with the transient dependency on Perhaps you need to We support both major versions: laminas-diactoros/composer.json Line 39 in 4db5273
|
That is fine BTW: we don't plan to release all libraries before PHP 8.3 is released, and in fact, we are working towards improving our dependency upgrades on that when the latest |
I tried the suggested lock for http-message, but then shows the actual issue and why the PHP8.3 support for 2.x series was thought to be the only viable path:
https://github.com/cakephp/cakephp/actions/runs/6653289986/job/18078957898#step:18:183 We would have to move several functions / classes into our namespace in order for it to work out: |
@laminas/technical-steering-committee do we want to do another |
Did we replace the sapi thing? if so, there might be an alternative. cake could check if function exist to make itself compatible with both versions. |
Regarding php support of v2, if that is doable without code changes, I would probably not mind backporting it. |
The problem with issuing a new minor on v2 is that we then need to support that branch for another 3 years with security fixes. Considering the number of changes in v3, this could potentially be a lot of work for us to maintain. |
I don't think you do, you can also state that in the release. |
If the changes are that minimal, you can also just do a patch release on
A minor seems almost overkill to quickly allow something that is quite obvious in nature regarding compatibility and in light of 2023/2024 support of PHP. |
This is simply not true. We have a published security policy, and it states that we maintain a release branch until the minimum supported PHP version is no longer supported by php.net. What you think is beside the point here; we are the ones who have to maintain it, and making exceptions to things like security policies loses our users' trust in the project. If we make a new release branch, we have to maintain it.
However, again, our policy is that we only add support for new PHP versions in new minor releases. There are a ton of reasons why we do this, and I'm not going to go into them here. I'm not saying we won't do it; I'm pointing out the ramifications of doing it so that those of us on the steering committee know what we are committing to if we do so. |
It seems to work fine with PHP 8.3 without any code changes https://github.com/ADmad/laminas-diactoros/actions/runs/6667118891 |
@ADmad send a patch against 2.26.x (with |
Resolved via #176 |
Thanks you guys for this. Really appreciate the fact that the laminas team is willing to make changes to accommodate down stream users. |
Summary
PHP 8.3 support is needed for 2.x series.
See
cakephp/cakephp#17387
Current behavior
Not installable, probably for no good reason as 8.3 should be compatible out of the box
How to reproduce
See above link
Expected behavior
~8.3 included in the constraint for PHP so folks stuck on that 2.x series of this library can still do 8.3 checking and development of their library code.
Many libraries and frameworks will have to support their major versions for a few years longer, so it is important that they can ship with secure/safe PHP versions in the present and future.
As per semver they cannot just modify their public API and as such are locked within 2.x series for now (no types added etc).
Thank you
The text was updated successfully, but these errors were encountered: