-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PHP 8.1 deprecated warnings #41
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
/coveralls-upload.json | ||
/phpunit.xml | ||
/vendor/ | ||
/.phpunit.result.cache |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,11 +2,13 @@ | |
|
||
namespace Laminas\DeveloperTools\Collector; | ||
|
||
use Serializable; | ||
|
||
/** | ||
* Serializable Collector base class. | ||
* | ||
*/ | ||
abstract class AbstractCollector implements CollectorInterface, \Serializable | ||
abstract class AbstractCollector implements CollectorInterface, Serializable | ||
{ | ||
/** | ||
* Collected Data | ||
|
@@ -15,19 +17,31 @@ abstract class AbstractCollector implements CollectorInterface, \Serializable | |
*/ | ||
protected $data; | ||
|
||
public function __serialize() | ||
{ | ||
return serialize($this->data); | ||
} | ||
|
||
/** | ||
* @see \Serializable | ||
* @deprecated since 2.3.0, this method will be removed in version 3.0.0 of this component. | ||
* {@see Serializable} as alternative | ||
*/ | ||
public function serialize() | ||
{ | ||
return serialize($this->data); | ||
return $this->__serialize(); | ||
} | ||
|
||
public function __unserialize($data) | ||
{ | ||
$this->data = unserialize($data); | ||
} | ||
Comment on lines
+34
to
37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See above, |
||
|
||
/** | ||
* @see \Serializable | ||
* @deprecated since 2.3.0, this method will be removed in version 3.0.0 of this component. | ||
* {@see Serializable} as alternative | ||
*/ | ||
public function unserialize($data) | ||
{ | ||
$this->data = unserialize($data); | ||
$this->__unserialize($data); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snapshotpl Shouldn't this return an array instead of a serialized string? From https://www.php.net/manual/language.oop5.magic.php#object.serialize:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@driehle
Good catch! 👍
Please create an issue report or a pull request for this problem. Thanks in advance!