Remove PHP 8.1 deprecated warnings #41
Conversation
Signed-off-by: Witold Wasiczko <[email protected]>
snapshotpl
changed the title
Signed-off-by: Witold Wasiczko <[email protected]>
snapshotpl
force-pushed
the
remove-8.1-deprecations
branch
from
482ee23 to
039f19a
Compare
Co-authored-by: Abdul Malik Ikhsan <[email protected]>
|
Thank you @snapshotpl |
| public function __serialize() | ||
| { | ||
| return serialize($this->data); | ||
| } |
There was a problem hiding this comment.
@snapshotpl Shouldn't this return an array instead of a serialized string? From https://www.php.net/manual/language.oop5.magic.php#object.serialize:
public __serialize(): array
public __unserialize(array $data): voidserialize() checks if the class has a function with the magic name __serialize(). If so, that function is executed prior to any serialization. It must construct and return an associative array of key/value pairs that represent the serialized form of the object. If no array is returned a TypeError will be thrown.
There was a problem hiding this comment.
@driehle
Good catch! 👍
Please create an issue report or a pull request for this problem. Thanks in advance!
| public function __unserialize($data) | ||
| { | ||
| $this->data = unserialize($data); | ||
| } |
There was a problem hiding this comment.
See above, $data should be an array at this point, i.e. no need to call unserialize().
Description
Remove deprecated warnings when run phpunit and developer-tools itself.