-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infection/infection
to CI runs, when infection.json(.dist)
exists
#59
Add infection/infection
to CI runs, when infection.json(.dist)
exists
#59
Conversation
Note: this removes BC checks, which are currently not running for PHP 8.x Ref: laminas/laminas-ci-matrix-action#59 Ref: laminas/laminas-ci-matrix-action#60 Ref: Roave/BackwardCompatibilityCheck#283 Ref: Roave/BetterReflection#701
Usually, I do add This will output the JSON and you can verify if it works as intended. |
@Ocramius I think I will start working on this on sunday as I want to kick out 1.11.0 as there are plenty of features I've added in the past weeks. If you want to dive into this by yourself, just hit me up. |
…is-plugin` or `infection/infection` is being used Signed-off-by: Maximilian Bösing <[email protected]>
0a52ebe
to
b9d6a6c
Compare
Signed-off-by: Maximilian Bösing <[email protected]>
@Ocramius would you mind double-checking the recent changes? If this suits your needs, I'd love to merge this PR |
Signed-off-by: Maximilian Bösing <[email protected]>
@boesing interestingly, all my CI actions failed today :D Reason: xdebug or pcov missing. What's the best way to handle that, in your opinion? Should a |
As mentioned in slack: adding |
I mostly preferred going with phpdbg because it is developed together with the PHP engine. Means 8.2 will have phpdbg out of the box :) XDebug and pcov are fine, but there's always some wait time in between |
Description
Fixes #3
Adds
vendor/bin/infection
to executed CI pipeline matrix, wheninfection.json
orinfection.json.dist
exist.Note: I've not yet includedroave/infection-static-analysis-plugin
, which requires checkingcomposer.json
orvendor/bin/roave-infection-static-analysis-plugin
(probably the former, sincecomposer install
happens inside the job, and not in the matrix)I'm quite uncomfortable with this tooling not having tests/QA on its own, so I don't have a valid way to verify if my code does what it should do 🤔