Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include roave/backward-compatibility-check in CI runs #60

Open
Ocramius opened this issue Sep 19, 2021 · 0 comments
Open

Include roave/backward-compatibility-check in CI runs #60

Ocramius opened this issue Sep 19, 2021 · 0 comments
Labels
Enhancement

Comments

@Ocramius
Copy link
Member

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

https://github.com/Roave/BackwardCompatibilityCheck helps in guaranteeing that no accidental BC breaks land in existing code in minor/patch releases.

My suggestion is to add a CI action that:

This could be a bit trickier than usual, because:

  • we need to git fetch the latest release, as well as HEAD
  • we need to make sure we're comparing HEAD against the correct release: depends on the target branch of a pull request
Ocramius added a commit to Ocramius/GeneratedHydrator that referenced this issue Sep 19, 2021
@Ocramius
Used CI from laminas/ to avoid repeated effort
f5c18b0 
Note: this removes BC checks, which are currently not running for PHP 8.x

Ref: laminas/laminas-ci-matrix-action#59
Ref: laminas/laminas-ci-matrix-action#60
Ref: Roave/BackwardCompatibilityCheck#283
Ref: Roave/BetterReflection#701
@boesing boesing linked a pull request Oct 10, 2021 that will close this issue
Add infection/infection to CI runs, when infection.json(.dist) exists #59
Merged
@boesing boesing removed a link to a pull request Oct 10, 2021
Add infection/infection to CI runs, when infection.json(.dist) exists #59
Merged
@Ocramius Ocramius mentioned this issue May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ocramius