Correct hover popup position on right side drawer #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to test these changes in neovim, but I can't seem to figure out how to get popup support working ¯_(ツ)_/¯ @hrsh7th would you be willing to give these changes a try? Would be greatly appreciated! |
|
I asked @hrsh7th to check this so he will check it when he got time 👍 |
hrsh7th
reviewed
Oct 18, 2022
|
I've checked the behavior. It works good. I leave the little review comment. I think it could be merged after resolved the review point. |
hrsh7th
approved these changes
Oct 18, 2022
When navigating through nodes in a drawer window, node names that extend beyond the width of the fern window are shown in a popup to display the full name to the user. A regression introduced in 10dd4bb (Improve hover popup behavior, 2022-03-16) prevented the popup from being positioned correctly in drawer windows positioned on the right side. As a result, the hover popup behavior was disabled for right hand drawers in ab237a1 (Merge pull request lambdalisue#419 from lambdalisue/fix-popup-right, 2022-04-15). This revision reintroduces this functionality, ensuring that the popup windows are positioned correctly in all cases.
brandon1024
force-pushed
the
popup-fix
branch
from
df016aa
to
71345e7
Compare
|
Thanks for your help @hrsh7th ! |
|
I'm sorry but force-pushed so could you review again? @hrsh7th |
hrsh7th
approved these changes
Oct 18, 2022
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating through nodes in a drawer window, node names that extend beyond the width of the fern window are shown in a popup to display the full name to the user.
A regression introduced in 10dd4bb (Improve hover popup behavior, 2022-03-16) prevented the popup from being positioned correctly in drawer windows positioned on the right side. As a result, the hover popup behavior was disabled for right hand drawers in ab237a1 (Merge pull request #419 from lambdalisue/fix-popup-right, 2022-04-15).
This revision reintroduces this functionality, ensuring that the popup windows are positioned correctly in all cases.
Fixes #418
Notes
I haven't tested this in neovim. I don't use neovim myself, so any assistance would be hugely appreciated!
Screenshots
Popup text doesn't wrap like it used to, which was an undeseriable quirk of the first revision of this feature.
Popup is not shown when the text fits in the window perfectly.
Identical behaviour for left-handed drawer windows.