Enable hover_popup feature only on left sided drawer #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon1024
added a commit
to brandon1024/fern.vim
that referenced
this pull request
Oct 15, 2022
When navigating through nodes in a drawer window, node names that extend beyond the width of the fern window are shown in a popup to display the full name to the user. A regression introduced in 10dd4bb (Improve hover popup behavior, 2022-03-16) prevented the popup from being positioned correctly in drawer windows positioned on the right side. As a result, the hover popup behavior was disabled for right hand drawers in ab237a1 (Merge pull request lambdalisue#419 from lambdalisue/fix-popup-right, 2022-04-15). This revision reintroduces this functionality, ensuring that the popup windows are positioned correctly in all cases.
brandon1024
added a commit
to brandon1024/fern.vim
that referenced
this pull request
Oct 18, 2022
When navigating through nodes in a drawer window, node names that extend beyond the width of the fern window are shown in a popup to display the full name to the user. A regression introduced in 10dd4bb (Improve hover popup behavior, 2022-03-16) prevented the popup from being positioned correctly in drawer windows positioned on the right side. As a result, the hover popup behavior was disabled for right hand drawers in ab237a1 (Merge pull request lambdalisue#419 from lambdalisue/fix-popup-right, 2022-04-15). This revision reintroduces this functionality, ensuring that the popup windows are positioned correctly in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #418