Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v3.1.0 #474

Merged
merged 20 commits into from
May 13, 2018
Merged

Release v3.1.0 #474

merged 20 commits into from
May 13, 2018

Conversation

rimiti
Copy link
Contributor

@rimiti rimiti commented Apr 23, 2018 •
edited
Loading

reallistic and others added 13 commits August 31, 2015 11:26
@reallistic
Removed ambiguously misappropriated cultural references from readme
ba31e14
@kevinburke
Add post() examples to the README
8df9c43 
I have to look up how to do a POST request every time, for JSON and
x-www-form-urlencoded.

Many of the existing examples duplicate themselves, so I figured we
could change some of them to demonstrate the different ways to send a
POST request without changing the flow too much.
@mikec
Add a .host() method to set a host other than 127.0.0.1
11a10ea 
This allows you to set the server hostname before making a
request. If no hostname is set then it defaults to 127.0.0.1
@bkeepers
Always pass on errors if no response
389c831
@fadi-william
Upgrade the superagent node module to resolve security vulnerabilitie…
0ebb06e 
…s and fix the __proto__ property deprecation
@rimiti
chore(.travis.yml) node versions updated
73d93b9
@pedro-otero
Remove unused dependency in Readme.MD snippet
39bb1e2
@rimiti
Merge pull request #473 from pedro-otero/patch-1
fec7fbe 
Remove unused dependency in Readme.MD snippet
@rimiti
Merge pull request #472 from visionmedia/update-travis-node-versions
d10b48f 
Update travis node versions
@rimiti
Merge pull request #297 from mikec/master
9c9c0ea 
Add a .host() method to set a host other than 127.0.0.1
@rimiti
Merge pull request #446 from bkeepers/unknown-errors
a28f04c 
Always pass on errors if no response
@rimiti
Merge pull request #418 from kevinburke/add-example
9e5f30a 
Add post() examples to the README
@rimiti
Merge pull request #470 from levioza/master
a412bb5 
Upgrade the superagent node module to resolve security vulnerabilities & fix the __proto__ property deprecation
@rimiti rimiti added this to the v3.1.0 milestone Apr 23, 2018
@rimiti rimiti assigned tj and mikelax Apr 23, 2018
@rimiti rimiti requested a review from mikelax April 23, 2018 09:54
@rimiti rimiti unassigned tj Apr 23, 2018
@rimiti rimiti requested a review from tj April 23, 2018 09:55
@rimiti
Copy link
Contributor Author

rimiti commented Apr 24, 2018

Release preparation done, I need your reviews to merge and publish it.

@mgcrea
Copy link

mgcrea commented Apr 27, 2018

@rimiti any chance you could release as v3.1.0-beta.0 so that anyone can easily test it and get more feedback from the field?

@vjustov
Copy link

vjustov commented Apr 27, 2018

Any chance we could squish #453 in here @rimiti ?

@outofambit
Copy link

@mgcrea you can install this branch directly with npm install visionmedia/supertest#release-v3.1.0 :)

mikelax
mikelax approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job. 💯 Thanks for assembling.
:shipit:

@mikelax
Copy link
Contributor

mikelax commented May 2, 2018

@rimiti thanks for the work on this, do you have access to merge the PR and push to npm?
If not I will take care of that today, then I can go through and clean up any older remaining issues or PRs that might be dups of this work.

@rimiti
Copy link
Contributor Author

rimiti commented May 2, 2018

Thanks @mikelax ! 👍
For the moment, I just can merge, not publishing.

@rimiti
Copy link
Contributor Author

rimiti commented May 13, 2018

@mikelax Can you give me the npm access to publish this new version ?

@mikelax mikelax merged commit d4a63af into master May 13, 2018
@mikelax mikelax deleted the release-v3.1.0 branch May 13, 2018 13:09
@mikelax
Copy link
Contributor

mikelax commented May 13, 2018

@rimiti I added you as a maintainer to npm.
Also I did merge this PR, publish a new version here on github and published v3.1.0 to npm!! 🚀

Thanks for the help in jumpstarting dev again.

@mikelax mikelax mentioned this pull request May 13, 2018
Closed
@rimiti
Copy link
Contributor Author

rimiti commented May 13, 2018 •
edited
Loading

You're welcome. ;)

@mikelax
Copy link
Contributor

mikelax commented May 13, 2018

@rimiti I just checked and noticed that for me one of the new tests are failing, this one:

should set request hostname
I am getting a timeout on the test. I tried changing the done(); to: return done(err); but the test still timed out.

This was referenced May 13, 2018
Closed
Closed
Closed
@markstos
Copy link

What about #453? @vjustov asked about including it in this release 17 days ago, but there was no response for the relesase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikelax mikelax mikelax approved these changes

@tj tj Awaiting requested review from tj

Assignees

@mikelax mikelax

Labels
bug enhancement release
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.