Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis node versions #472

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Conversation

rimiti
Copy link
Contributor

@rimiti rimiti commented Apr 19, 2018

Hello @mikelax,

Issue: #471

I thinks it should be smart to keep all LTS versions and including the latest version. What do you think about this proposal?

Regards,

@rimiti rimiti self-assigned this Apr 19, 2018
@rimiti rimiti requested a review from mikelax April 19, 2018 08:23
@rimiti rimiti force-pushed the update-travis-node-versions branch from 9522526 to 73d93b9 Compare April 19, 2018 08:29
@rimiti rimiti changed the base branch from master to release-v3.1.0 April 23, 2018 09:36
@rimiti rimiti merged commit d10b48f into release-v3.1.0 Apr 23, 2018
@rimiti rimiti added this to the v3.1.0 milestone Apr 23, 2018
@rimiti rimiti deleted the update-travis-node-versions branch April 23, 2018 09:37
@rimiti rimiti mentioned this pull request Apr 24, 2018
@mikelax
Copy link
Contributor

mikelax commented May 1, 2018

hey @rimiti node 4 is totally end of life, so I think it should be removed.
I think 6,8,9 is sufficient for now.

@rimiti rimiti restored the update-travis-node-versions branch May 2, 2018 08:57
@rimiti
Copy link
Contributor Author

rimiti commented May 2, 2018

You right @mikelax, I've updated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants