Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LogPipeline OTLP output base functionality #1624

Merged
merged 56 commits into from
Dec 2, 2024

Conversation

TeodorSAP
Copy link
Member

@TeodorSAP TeodorSAP commented Nov 21, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Implement LogPipeline reconciliation logic for LogPipelines with OTLP output (Which spins-up LogGateways)
  • Add a LogPipeline sample with OTLP output
  • Implement LogPipleine status ConfigurationGenerated and GatewayHealthy conditions checks
  • Add UTs and E2E tests for testing the basic flow

Changes refer to particular issues, PRs or documents:

Left To Do / Follow-up:

  • OTLP endpoint documented in the module CR status
  • Validators added to the reconciliation logic
  • AdditionalPrinterColumn added for GatewayHealthy condition, and NotRequired reason logic for Agent/Gateway (as we do for MetricPipeline)
  • Self-monitoring for LogPipeline with OTLP output (+ FlowHealthy condition checks)

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@TeodorSAP TeodorSAP added kind/feature Categorizes issue or PR as related to a new feature. area/logs LogPipeline labels Nov 21, 2024
@TeodorSAP TeodorSAP added this to the 1.29.0 milestone Nov 21, 2024
@TeodorSAP TeodorSAP requested a review from a team as a code owner November 21, 2024 14:44
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 21, 2024
@TeodorSAP TeodorSAP added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed cla: yes Indicates the PR's author has signed the CLA. labels Nov 21, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 21, 2024
@TeodorSAP TeodorSAP requested a review from a team as a code owner November 22, 2024 08:42
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 22, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 28, 2024
.testcoverage.yml Outdated Show resolved Hide resolved
.testcoverage.yml Outdated Show resolved Hide resolved
controllers/telemetry/logpipeline_controller.go Outdated Show resolved Hide resolved
@kyma-project kyma-project deleted a comment from TeodorSAP Nov 29, 2024
Copy link
Contributor

@k15r k15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create the followup tickets for the controller refactoring

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 29, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 29, 2024
@TeodorSAP
Copy link
Member Author

Follow-up Ticket For Controllers Refactoring:
#1644

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 2, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 2, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 2, 2024

New changes are detected. LGTM label has been removed.

@TeodorSAP TeodorSAP merged commit 496481d into kyma-project:main Dec 2, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants