generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LogPipeline OTLP output base functionality #1624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeodorSAP
added
kind/feature
Categorizes issue or PR as related to a new feature.
area/logs
LogPipeline
labels
Nov 21, 2024
TeodorSAP
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
and removed
cla: yes
Indicates the PR's author has signed the CLA.
labels
Nov 21, 2024
kyma-bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
labels
Nov 21, 2024
k15r
reviewed
Nov 29, 2024
internal/otelcollector/config/log/gateway/config_builder_test.go
Outdated
Show resolved
Hide resolved
internal/otelcollector/config/log/gateway/config_builder_test.go
Outdated
Show resolved
Hide resolved
internal/otelcollector/config/log/gateway/config_builder_test.go
Outdated
Show resolved
Hide resolved
k15r
reviewed
Nov 29, 2024
k15r
reviewed
Nov 29, 2024
k15r
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create the followup tickets for the controller refactoring
Follow-up Ticket For Controllers Refactoring: |
NHingerl
approved these changes
Dec 2, 2024
New changes are detected. LGTM label has been removed. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/logs
LogPipeline
cla: yes
Indicates the PR's author has signed the CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
ConfigurationGenerated
andGatewayHealthy
conditions checksChanges refer to particular issues, PRs or documents:
Left To Do / Follow-up:
AdditionalPrinterColumn
added forGatewayHealthy
condition, andNotRequired
reason logic for Agent/Gateway (as we do for MetricPipeline)Traceability
Related Issues
section.