Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor LogPipeline, MetricPipeline, and TracePipeline Controllers #1644

Open
TeodorSAP opened this issue Nov 29, 2024 · 0 comments
Open
Assignees
Labels
area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline kind/chore Categorizes issue or PR as related to a chore.

Comments

@TeodorSAP
Copy link
Member

TeodorSAP commented Nov 29, 2024

Description

The 3 controllers shall be refactored, such that when creating a reconciler, all the variables/constants describing parameters that will not externally change (e.g. dynamic/base CPU, Memory limits) won't have to be passed anymore.

The configurations of the respective gateways and agents have to be refactored accordingly. Such that this pattern is not present in our code anymore.

Reasons

  1. Bring these variables closer to where they are used, and make the controller code cleaner.
  2. Besides the name, namespace, and priorityClassName these attributes are not externally configurable anymore (since the corresponding feature flags have been removed)

Attachments

Example for LogPipeline:

https://github.com/kyma-project/telemetry-manager/blob/main/controllers/telemetry/logpipeline_controller.go#L69-L87

https://github.com/kyma-project/telemetry-manager/blob/main/controllers/telemetry/logpipeline_controller.go#L175-L192

https://github.com/kyma-project/telemetry-manager/blob/main/controllers/telemetry/logpipeline_controller.go#L224-L242

Release Notes


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline kind/chore Categorizes issue or PR as related to a chore.
Projects
None yet
Development

No branches or pull requests

1 participant