Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Parse metrics port from env #171

Merged
merged 2 commits into from
Dec 8, 2023
Merged

feat: Parse metrics port from env #171

merged 2 commits into from
Dec 8, 2023

Conversation

lindnerby
Copy link
Member

@lindnerby lindnerby commented Dec 8, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Read the metrics port from env var

Related issue(s)

@lindnerby lindnerby requested a review from a team as a code owner December 8, 2023 11:22
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 8, 2023
@kyma-bot kyma-bot merged commit f79eb40 into kyma-project:main Dec 8, 2023
8 checks passed
@lindnerby lindnerby deleted the configurable-metrics-port branch December 8, 2023 13:08
@lindnerby lindnerby assigned lindnerby and unassigned nesmabadr Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees

@lindnerby lindnerby

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindnerby @nesmabadr @kyma-bot