Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics: Introduce runtime-Watcher metrics #146

Closed
13 tasks done
jeremyharisch opened this issue Nov 6, 2023 · 1 comment
Closed
13 tasks done

Metrics: Introduce runtime-Watcher metrics #146

jeremyharisch opened this issue Nov 6, 2023 · 1 comment
Assignees
@lindnerby
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jeremyharisch
Copy link
Contributor

jeremyharisch commented Nov 6, 2023 •
edited by lindnerby
Loading

Description
At the moment, the runtime-watcher does not have any metrics.

Acceptance Criterias

  • Introduce metrics for runtime-watcher
    • failed-requests send to KCP
    • requests-total send to KCP
    • request-duration to KCP
    • Validation Requests to Runtime-Watcher
    • Webhook-errors (erros which happen here)
    • Which Watcher version is running
    • ... (come up with more we can make use of)
  • Clarify with SREs if we can leverage current solution which is used by other modules
    • Check what the solution is and if we can use it as well
    • Prepare knowledge sharing for the team, how it works
  • Introduce new Plutono dashboard to collect those metrics
    • Compare difference between TotalRequests to ValdiationRequests -> should be equal, to not make sure have have internal runtime-watcher errors
@jeremyharisch jeremyharisch added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 6, 2023
@lindnerby lindnerby assigned lindnerby and unassigned lindnerby Nov 24, 2023
@lindnerby lindnerby mentioned this issue Dec 1, 2023
Merged
This was referenced Dec 8, 2023
Merged
Merged
Merged
@lindnerby lindnerby mentioned this issue Dec 18, 2023
Merged
@lindnerby
Copy link
Member

Metrics are visible in dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindnerby lindnerby

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremyharisch @lindnerby