Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add skr-webhook-metrics service and provide metrics port #1146

Merged
merged 2 commits into from
Dec 8, 2023
Merged

feat: Add skr-webhook-metrics service and provide metrics port #1146

merged 2 commits into from
Dec 8, 2023

Conversation

lindnerby
Copy link
Member

@lindnerby lindnerby commented Dec 8, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add service for metrics endpoint
  • Add flag for metrics port
  • Update watcher img tag

Related issue(s)

@lindnerby lindnerby requested a review from a team as a code owner December 8, 2023 11:24
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 8, 2023
@lindnerby lindnerby added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Dec 8, 2023
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Dec 8, 2023
@lindnerby lindnerby removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 8, 2023
@kyma-bot kyma-bot merged commit 9b528fe into kyma-project:main Dec 8, 2023
23 checks passed
@ruanxin ruanxin assigned lindnerby and unassigned ruanxin Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanxin ruanxin ruanxin approved these changes

Assignees

@lindnerby lindnerby

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindnerby @ruanxin @kyma-bot