Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document dry run flag #99

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Document dry run flag #99

merged 2 commits into from
Jan 23, 2024

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Jan 19, 2024

Description

Changes proposed in this pull request:

  • Change dry-run label to kyma-project.io/cm-dry-run
  • Document env vars

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@VOID404 VOID404 marked this pull request as ready for review January 19, 2024 08:10
@VOID404 VOID404 requested a review from a team as a code owner January 19, 2024 08:10
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 19, 2024
@VOID404 VOID404 self-assigned this Jan 19, 2024
@VOID404 VOID404 force-pushed the feature/dry-run-docs branch from 527c8f1 to a13ff4f Compare January 19, 2024 08:13
@mvshao mvshao added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2024
grego952
grego952 reviewed Jan 19, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@VOID404 @grego952
Apply suggestions from code review
677f828 
Co-authored-by: Grzegorz Karaluch <[email protected]>
@VOID404 VOID404 force-pushed the feature/dry-run-docs branch from 77ce337 to 677f828 Compare January 22, 2024 07:38
@VOID404 VOID404 requested a review from grego952 January 22, 2024 07:38
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 22, 2024
@VOID404 VOID404 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
@VOID404 VOID404 merged commit 93b4627 into kyma-project:main Jan 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

Assignees

@VOID404 VOID404

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VOID404 @kyma-bot @grego952 @mvshao