Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history 
Co-authored-by: Grzegorz Karaluch <[email protected]>
  • Loading branch information
@VOID404 @grego952
VOID404 and grego952 committed Jan 22, 2024
1 parent a13ff4f commit 677f828
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
23 changes: 11 additions & 12 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,17 @@ make deploy

### Configuration Envs

| Name | Default | Description |
|------------------------------------|------------------------------------------------------------------------------|------------------------------------------------------------------------------------|
| `APP_ADDRESS` | `127.0.0.1:3000` | Adress on which the app will be exposed |
| `APP_APIENDPOINT` | `/graphql` | Endpoint for GraphQL requests |
| `APP_PLAYGROUNDAPIENDPOINT` | `/graphql` | This option is not used |
| `APP_SKIPDIRECTORCERTVERIFICATION` | `false` | Skip cert verification in Compass Director GraphQL calls |
| `APP_DIRECTOR_URL` | `https://compass-gateway-auth-oauth.mps.dev.kyma.cloud.sap/director/graphql` | URL of the Compass Director GraphQL endpoint |
| `APP_DIRECTOR_OAUTH_PATH` | `./dev/director.yaml` | File with OAuth data for Compass Director |
| `APP_ENABLED_REGISTRATION` | `false` | Enable registering runtimes with Compass |
| `APP_DRYRUN` | `false` | Disable registering and configuring, instead log what operations would be executed |

> **TIP:** `CompassManagerMappings` created with dry run will be labeled `kyma-project.io/cm-dry-run: Yes`
| Name | Default | Description |
|------------------------------------|------------------------------------------------------------------------------|-------------------------------------------------------------------------------------|
| `APP_ADDRESS` | `127.0.0.1:3000` | Address on which the app is exposed |
| `APP_APIENDPOINT` | `/graphql` | Endpoint for GraphQL requests |
| `APP_SKIPDIRECTORCERTVERIFICATION` | `false` | Skips cert verification in the Compass Director GraphQL calls |
| `APP_DIRECTOR_URL` | `https://compass-gateway-auth-oauth.mps.dev.kyma.cloud.sap/director/graphql` | URL of the Compass Director GraphQL endpoint |
| `APP_DIRECTOR_OAUTH_PATH` | `./dev/director.yaml` | File with OAuth data for Compass Director |
| `APP_ENABLED_REGISTRATION` | `false` | Enable registering runtimes with Compass |
| `APP_DRYRUN` | `false` | Disable registering and configuring; instead log which operations would be executed |

> **TIP:** `CompassManagerMappings` created with dry run are labeled `kyma-project.io/cm-dry-run: Yes`

> Explain how to use the project. You can create multiple subsections (H3). Include the instructions or provide links to the related documentation.

Expand Down
1 change: 0 additions & 1 deletion main.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ var (
type config struct {
Address string `envconfig:"default=127.0.0.1:3000"`
APIEndpoint string `envconfig:"default=/graphql"`
PlaygroundAPIEndpoint string `envconfig:"default=/graphql"`
SkipDirectorCertVerification bool `envconfig:"default=false"`
DirectorURL string `envconfig:"APP_DIRECTOR_URL,default=https://compass-gateway-auth-oauth.mps.dev.kyma.cloud.sap/director/graphql"`
DirectorOAuthPath string `envconfig:"APP_DIRECTOR_OAUTH_PATH,default=./dev/director.yaml"`
Expand Down

0 comments on commit 677f828

Please sign in to comment.