Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metrics #81

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Improve metrics #81

merged 4 commits into from
Jan 2, 2024

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Dec 22, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add statuses
  • Refactor

Related issue(s)

#28

@VOID404 VOID404 requested a review from a team as a code owner December 22, 2023 07:46
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2023
@VOID404 VOID404 linked an issue Dec 22, 2023 that may be closed by this pull request
Compass Manager - Add metrics to improve observability #28
Closed
koala7659
koala7659 previously requested changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that following jobs pass:

  • Run vuln check / test (pull_request)
  • golangci-lint / lint (pull_request)
  • pull-compass-manager-tests

Also please add more detailed description about the goal of changes in this PR

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 29, 2023
@Disper Disper mentioned this pull request Dec 29, 2023
Closed
@VOID404 VOID404 requested a review from koala7659 December 29, 2023 14:47
@VOID404 VOID404 removed the request for review from koala7659 January 2, 2024 08:19
@kyma-bot kyma-bot merged commit 000a224 into kyma-project:main Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disper Disper Disper approved these changes

@koala7659 koala7659 koala7659 left review comments

Assignees

@Disper Disper

@koala7659 koala7659

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compass Manager - Add metrics to improve observability
4 participants
@VOID404 @Disper @koala7659 @kyma-bot