Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compass Manager - Add metrics to improve observability #28

Closed
Tracked by #80
akgalwas opened this issue Sep 20, 2023 · 2 comments · Fixed by #81
Closed
Tracked by #80

Compass Manager - Add metrics to improve observability #28

akgalwas opened this issue Sep 20, 2023 · 2 comments · Fixed by #81
Assignees
@VOID404 @koala7659

Comments

@akgalwas
Copy link
Contributor

Description

Compass Manager should provide metrics to allow early issues detection.

Reasons

Compass Manager is a component that is responsible for Compass integration. In case of a downtime the impact on Kyma Control Plane will be significant. We must prevent that by increasing the observability.
@akgalwas akgalwas changed the title Infrastructure Manager - add metrics to improve observability Compass Manager - add metrics to improve observability Sep 20, 2023
@akgalwas akgalwas self-assigned this Sep 20, 2023
@akgalwas akgalwas changed the title Compass Manager - add metrics to improve observability Compass Manager - Add metrics to improve observability Sep 20, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 19, 2023
@Disper Disper removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 23, 2023
@VOID404 VOID404 self-assigned this Dec 11, 2023
@VOID404 VOID404 mentioned this issue Dec 14, 2023
Merged
@Disper Disper assigned koala7659 and unassigned akgalwas Dec 18, 2023
kyma-bot added a commit that referenced this issue Dec 18, 2023
@kyma-bot
Add metrics (#67)
554b286 
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**

Initial metrics PR, more metrics will be added when dashboard is
connected

**Related issue(s)**
<!-- If you refer to a particular issue, provide its number. For
example, `Resolves #123`, `Fixes #43`, or `See also #33`. -->
#28
@VOID404 VOID404 mentioned this issue Dec 22, 2023
Merged
@VOID404 VOID404 linked a pull request Dec 22, 2023 that will close this issue
Improve metrics #81
Merged
@tobiscr tobiscr mentioned this issue Dec 27, 2023
Open
7 tasks
@Disper
Copy link
Member

Disper commented Dec 29, 2023

@VOID404 I gave ✅ in #81 but I would like to still see how this looks like in Plutono. Please let me know when those changes will be available.

kyma-bot added a commit that referenced this issue Jan 2, 2024
@kyma-bot
Improve metrics (#81)
000a224 
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**

Changes proposed in this pull request:

- Add statuses
- Refactor

**Related issue(s)**
<!-- If you refer to a particular issue, provide its number. For
example, `Resolves #123`, `Fixes #43`, or `See also #33`. -->
#28
@Disper Disper reopened this Jan 2, 2024
@VOID404 VOID404 mentioned this issue Jan 4, 2024
Merged
kyma-bot added a commit that referenced this issue Jan 4, 2024
@kyma-bot
Fix metric "Ready" bug (#88)
0adccb4 
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**

Changes proposed in this pull request:

- Correct metrics for `Ready` status

**Related issue(s)**
<!-- If you refer to a particular issue, provide its number. For
example, `Resolves #123`, `Fixes #43`, or `See also #33`. -->
#28
@tobiscr tobiscr mentioned this issue Jan 29, 2024
Closed
23 tasks
@tobiscr tobiscr closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VOID404 VOID404

@koala7659 koala7659

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve metrics VOID404/compass-manager
6 participants
@Disper @VOID404 @akgalwas @koala7659 @kyma-bot @tobiscr