Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modules): modules version adjustments to moduleCatalog changes #3500

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Nov 25, 2024

Description

Changes proposed in this pull request:

  • adjust Add Modules view to take data for modules from ModuleMetaRelease if ModuleTemplate is not available
  • adjust Edit Modules view to take data for modules from ModuleMetaRelease if ModuleTemplate is not available
  • adjust List view of the modules, to take channel from KymaCR.spec.[modules].channel is KymaCR.status.[modules].channel is not avaibale

Related issue(s)
Closes #3459

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2024
@mrCherry97 mrCherry97 marked this pull request as ready for review November 26, 2024 07:51
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2024
@mrCherry97
Copy link
Contributor Author

Info for the reviewer: catch me up for testing environment.

@OliwiaGowor OliwiaGowor self-assigned this Dec 2, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 2, 2024
@mrCherry97 mrCherry97 merged commit 0519973 into kyma-project:main Dec 3, 2024
35 checks passed
@mrCherry97 mrCherry97 deleted the add-modules branch December 3, 2024 07:29
pbochynski pushed a commit to pbochynski/busola that referenced this pull request Dec 6, 2024
…yma-project#3500)

* feat: modules version adjustments to moduleCatalog changes

* adjust edit view

* adjust list view of the modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust Add Modules view to latest Module Catalog changes
3 participants