Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace release label validator script #519

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Replace release label validator script #519

merged 2 commits into from
Dec 7, 2023

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Dec 5, 2023 •
edited
Loading

Description

Replace the existing bash label validation script with a python script. This new script will only be used during release. Validation at the PR level will still be done by the old bash script. Also remove the v prefix from latest release when doing upgrade test.

Changes proposed in this pull request:

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2023
@MarekMichali MarekMichali added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Dec 5, 2023
@MarekMichali MarekMichali marked this pull request as ready for review December 5, 2023 11:03
@MarekMichali MarekMichali requested a review from a team as a code owner December 5, 2023 11:03
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2023
@MarekMichali
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 6, 2023
@MarekMichali
Copy link
Contributor Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@kyma-bot kyma-bot merged commit dc9444c into kyma-project:main Dec 7, 2023
18 checks passed
ukff added a commit to ukff/btp-manager that referenced this pull request Dec 12, 2023
@ukff @jaroslaw-pieszka
@dependabot @MarekMichali @IwonaLanger @kyma-gopher-bot
Topsapbtpoperator (#110)
6f44245 
* Using the most recent minor versions of k3s for tests (kyma-project#489)

* initial commit

* testing - do not push release

* testing - do not push release

* testing - do not push release

* conditional publish

* referencing env

* based on input

* conditional but inline

* start e2e right away

* validate settings

* no extra validation

* comment improved

* label validator improvements (kyma-project#491)

* wip - temp commit msg

* docker(deps): bump golang from 1.21.3 to 1.21.4 (kyma-project#490)

Bumps golang from 1.21.3 to 1.21.4.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* gomod(deps): bump github.com/onsi/gomega from 1.28.0 to 1.30.0 (kyma-project#492)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.28.0 to 1.30.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.28.0...v1.30.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* gomod(deps): bump github.com/onsi/ginkgo/v2 from 2.13.0 to 2.13.1 (kyma-project#495)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.13.0 to 2.13.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.13.0...v2.13.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Select k3s1 releases only for end to end testing (kyma-project#496)

* k3s1 releases only

* comments corrected

* comments corrected in the workflow

* Clobber switch added for curl invocation (kyma-project#501)

clobber for curl

* PR body corrected and curl invocation corrected (kyma-project#502)

* PR body corrected

* clobber removed

* gomod(deps): bump k8s.io/client-go from 0.28.3 to 0.28.4 (kyma-project#498)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.28.3 to 0.28.4.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.28.3...v0.28.4)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* gomod(deps): bump k8s.io/apiextensions-apiserver from 0.28.3 to 0.28.4 (kyma-project#500)

Bumps [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) from 0.28.3 to 0.28.4.
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.28.3...v0.28.4)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Rename kyma-btp-manager-bot (kyma-project#503)

* Documentation update for new E2E (matrix) approach (kyma-project#497)

* documentation update

* Update docs/contributor/03-10-release.md

Co-authored-by: Iwona Langer <[email protected]>

* Update docs/contributor/03-10-release.md

Co-authored-by: Iwona Langer <[email protected]>

* Update docs/contributor/04-10-workflows.md

Co-authored-by: Iwona Langer <[email protected]>

* Update docs/contributor/04-10-workflows.md

Co-authored-by: Iwona Langer <[email protected]>

* Update docs/contributor/04-10-workflows.md

Co-authored-by: Iwona Langer <[email protected]>

---------

Co-authored-by: Iwona Langer <[email protected]>

* Remove 'v' prefix from module-tag (kyma-project#505)

* Remove 'v' prefix from module-tag in workflows (kyma-project#506)

* Remove 'v' prefix from module-tag in  promotion workflow

* Remove 'v' from release workflow

* Remove 'v' from release workflow

* Remove 'v' from release workflow

* Fix autobump step skip (kyma-project#507)

* Restore 'v' in module tag for upgrade test (kyma-project#508)

* Convert toggles into docsify tabs (kyma-project#504)

* Convert toggles into docsify tabs

* Apply review suggestion

* Convert toggles into docsify tabs

* Apply review suggestion

* Fix for last-k3s-versions parameter in e2e tests (kyma-project#509)

* last parameter type changed to string

* dry run introduced

* Draft release is a must even for dry-run (kyma-project#512)

Draft is a need

* Removal of security config file (kyma-project#513)

removal of security config file

* Bump sec-scanners-config.yaml to 1.0.2 (kyma-project#514)

* Handle skipping final step in E2E tests (kyma-project#516)

* Handle skipping final step

* force test failure to test workflow

* shorter verdict evaluation

* removed forced failure

* example invocation corrected

* gomod(deps): bump github.com/onsi/ginkgo/v2 from 2.13.1 to 2.13.2 (kyma-project#515)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.13.1 to 2.13.2.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.13.1...v2.13.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Run name added to create release workflow (kyma-project#521)

run name added

* Replace release label validator script (kyma-project#519)

* Replace release label validator script

* Remove v from upgrade test

* Adjust the docs to the new content guidelines (kyma-project#524)

* Adjust the docs to the new contribution guidelines

* Apply a review suggestion

* Capitalize one more heading

* wip - temp commit msg

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jarosław Pieszka <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marek Michali <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Kyma gopher bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarekMichali @kyma-bot @jaroslaw-pieszka