Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR body corrected and curl invocation corrected #502

Merged
merged 2 commits into from
Nov 16, 2023
Merged

PR body corrected and curl invocation corrected #502

merged 2 commits into from
Nov 16, 2023

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Nov 16, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • URL for btp-manager was incorrect
  • curl overwrites local files

Related issue(s)

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner November 16, 2023 10:09
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Nov 16, 2023
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2023
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2023
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2023
@jaroslaw-pieszka jaroslaw-pieszka changed the title PR body corrected PR body corrected and curl invocation corrected Nov 16, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 16, 2023
@kyma-bot kyma-bot merged commit e42c43d into kyma-project:main Nov 16, 2023
14 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the pr_description_corrected branch November 27, 2023 09:40
ukff added a commit to ukff/btp-manager that referenced this pull request Dec 12, 2023
@ukff @jaroslaw-pieszka
@dependabot @MarekMichali @IwonaLanger @kyma-gopher-bot
Topsapbtpoperator (#110)
6f44245 
* Using the most recent minor versions of k3s for tests (kyma-project#489)

* initial commit

* testing - do not push release

* testing - do not push release

* testing - do not push release

* conditional publish

* referencing env

* based on input

* conditional but inline

* start e2e right away

* validate settings

* no extra validation

* comment improved

* label validator improvements (kyma-project#491)

* wip - temp commit msg

* docker(deps): bump golang from 1.21.3 to 1.21.4 (kyma-project#490)

Bumps golang from 1.21.3 to 1.21.4.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* gomod(deps): bump github.com/onsi/gomega from 1.28.0 to 1.30.0 (kyma-project#492)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.28.0 to 1.30.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.28.0...v1.30.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* gomod(deps): bump github.com/onsi/ginkgo/v2 from 2.13.0 to 2.13.1 (kyma-project#495)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.13.0 to 2.13.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.13.0...v2.13.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Select k3s1 releases only for end to end testing (kyma-project#496)

* k3s1 releases only

* comments corrected

* comments corrected in the workflow

* Clobber switch added for curl invocation (kyma-project#501)

clobber for curl

* PR body corrected and curl invocation corrected (kyma-project#502)

* PR body corrected

* clobber removed

* gomod(deps): bump k8s.io/client-go from 0.28.3 to 0.28.4 (kyma-project#498)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.28.3 to 0.28.4.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.28.3...v0.28.4)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* gomod(deps): bump k8s.io/apiextensions-apiserver from 0.28.3 to 0.28.4 (kyma-project#500)

Bumps [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) from 0.28.3 to 0.28.4.
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.28.3...v0.28.4)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Rename kyma-btp-manager-bot (kyma-project#503)

* Documentation update for new E2E (matrix) approach (kyma-project#497)

* documentation update

* Update docs/contributor/03-10-release.md

Co-authored-by: Iwona Langer <[email protected]>

* Update docs/contributor/03-10-release.md

Co-authored-by: Iwona Langer <[email protected]>

* Update docs/contributor/04-10-workflows.md

Co-authored-by: Iwona Langer <[email protected]>

* Update docs/contributor/04-10-workflows.md

Co-authored-by: Iwona Langer <[email protected]>

* Update docs/contributor/04-10-workflows.md

Co-authored-by: Iwona Langer <[email protected]>

---------

Co-authored-by: Iwona Langer <[email protected]>

* Remove 'v' prefix from module-tag (kyma-project#505)

* Remove 'v' prefix from module-tag in workflows (kyma-project#506)

* Remove 'v' prefix from module-tag in  promotion workflow

* Remove 'v' from release workflow

* Remove 'v' from release workflow

* Remove 'v' from release workflow

* Fix autobump step skip (kyma-project#507)

* Restore 'v' in module tag for upgrade test (kyma-project#508)

* Convert toggles into docsify tabs (kyma-project#504)

* Convert toggles into docsify tabs

* Apply review suggestion

* Convert toggles into docsify tabs

* Apply review suggestion

* Fix for last-k3s-versions parameter in e2e tests (kyma-project#509)

* last parameter type changed to string

* dry run introduced

* Draft release is a must even for dry-run (kyma-project#512)

Draft is a need

* Removal of security config file (kyma-project#513)

removal of security config file

* Bump sec-scanners-config.yaml to 1.0.2 (kyma-project#514)

* Handle skipping final step in E2E tests (kyma-project#516)

* Handle skipping final step

* force test failure to test workflow

* shorter verdict evaluation

* removed forced failure

* example invocation corrected

* gomod(deps): bump github.com/onsi/ginkgo/v2 from 2.13.1 to 2.13.2 (kyma-project#515)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.13.1 to 2.13.2.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.13.1...v2.13.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Run name added to create release workflow (kyma-project#521)

run name added

* Replace release label validator script (kyma-project#519)

* Replace release label validator script

* Remove v from upgrade test

* Adjust the docs to the new content guidelines (kyma-project#524)

* Adjust the docs to the new contribution guidelines

* Apply a review suggestion

* Capitalize one more heading

* wip - temp commit msg

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jarosław Pieszka <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marek Michali <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Kyma gopher bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PK85 PK85 PK85 approved these changes

Assignees

@PK85 PK85

@jaroslaw-pieszka jaroslaw-pieszka

Labels
kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @PK85 @kyma-bot