-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandas pyarrow backend #3058
Pandas pyarrow backend #3058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, we should resolve the type of the dataframe during compile time(in replacement function) instead of run time.
add4965
to
e281d5c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3058 +/- ##
==========================================
- Coverage 92.61% 91.91% -0.70%
==========================================
Files 1161 1169 +8
Lines 43107 43736 +629
==========================================
+ Hits 39923 40202 +279
- Misses 3184 3534 +350 ☔ View full report in Codecov by Sentry. |
f2fae8f
to
9e5a0d8
Compare
e77feed
to
5dca7c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see quite a few types missing test coverage, can you see if you can add more tests?
@acquamarin should take a look at changes on function side.
Sure. I'm going to try making every relevant change in this PR, though some changes may have to be implemented in a future PR. |
2e49f63
to
ab267a1
Compare
f378790
to
94d30b2
Compare
formatting checks remove disabled tests more clang format fixes... py lint check clang tidy more clang tidy and py lint checks more and more clang tidy explicit pyarrow scan ctor possibly fixed tests not running? CI fixes fix pytest non portable type resolution solution apple clang test fix? add some requested changes apply backend switching remove fixed list update httpfs version & remove python-debug clang tidy fix array arithmetic on void revert extension version change apply clang-tidy fix compiler errors ... more clang-tidy fixes added requested changes clang-tidy
738bc2a
to
cb4d757
Compare
Progress:
Areas for General Improvement
Extra changes:
ValueVector::getValue
previously returned non const reference to Value, despite being a const method. It now returns a const reference if the class is const, and a non const reference if the class is non constValueVector::setNullFromBits
now has invert parameter that allows for copying of inverted bitmaps.Edit: I forgot to mention that most of the tests are randomly generated. However, the random number generator is seeded, so the data generation is deterministic.
Edit 2: More tests will be added in future PRs.