Skip to content

Commit

Permalink
remove fixed list
Browse files Browse the repository at this point in the history
  • Loading branch information
mxwli committed Mar 21, 2024
1 parent 8b7e2a2 commit 2e49f63
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/common/arrow/arrow_array_scan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,8 @@ static void scanArrowArrayVarListView(const ArrowSchema* schema, const ArrowArra
}
}
}

/*
TODO manh: scan arrow fixed list
static void scanArrowArrayFixedList(const ArrowSchema* schema, const ArrowArray* array,
ValueVector* outputVector, ArrowNullMaskTree* mask, int64_t srcOffset, int64_t dstOffset,
int64_t cnt) {
Expand All @@ -201,6 +202,7 @@ static void scanArrowArrayFixedList(const ArrowSchema* schema, const ArrowArray*
mask->getChild(0), srcOffset * numValuesInList, dstOffset * numValuesInList,
cnt * numValuesInList);
}
*/

static void scanArrowArrayStruct(const ArrowSchema* schema, const ArrowArray* array,
ValueVector* outputVector, ArrowNullMaskTree* mask, int64_t srcOffset, int64_t dstOffset,
Expand Down Expand Up @@ -491,8 +493,8 @@ void ArrowConverter::fromArrowArray(const ArrowSchema* schema, const ArrowArray*
// FIXED_LIST
// TODO Manh: Array Scanning
KU_UNREACHABLE;
return scanArrowArrayFixedList(
schema, array, outputVector, mask, srcOffset, dstOffset, cnt);
//return scanArrowArrayFixedList(
// schema, array, outputVector, mask, srcOffset, dstOffset, cnt);
case 's':
// STRUCT
return scanArrowArrayStruct(
Expand Down

0 comments on commit 2e49f63

Please sign in to comment.