Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubectl) support dots in variables name #636

Merged
merged 3 commits into from
Mar 18, 2020
Merged

fix(kubectl) support dots in variables name #636

merged 3 commits into from
Mar 18, 2020

Conversation

lobkovilya
Copy link
Contributor

Summary

Command kumactl apply -v ... now has support of variables with dots in the name.

Full changelog

  • Build nested context for mustache.Render function based on passed variable name.

Issues resolved

Fix https://github.com/Kong/kuma/issues/614

@lobkovilya lobkovilya requested a review from a team March 17, 2020 13:53
@lobkovilya lobkovilya force-pushed the fix/var-names-with-dots branch from 3460b04 to 5d86427 Compare March 17, 2020 13:54
@lobkovilya lobkovilya merged commit 97cd767 into master Mar 18, 2020
@devadvocado devadvocado deleted the fix/var-names-with-dots branch March 30, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lobkovilya @jakubdyszkiewicz