Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kumactl apply --var name=value command should support variable names that include . (dot) character, e.g. ansible_facts.default_ipv4.address #614

Closed
yskopets opened this issue Mar 1, 2020 · 0 comments · Fixed by #636
Labels
good first issue Good for newcomers

Comments

@yskopets
Copy link
Contributor

yskopets commented Mar 1, 2020

Summary

  • kumactl apply --var name=value command should support variable names that include . (dot) character, e.g. ansible_facts.default_ipv4.address

Steps To Reproduce

  1. Run

    echo "
    type: Dataplane
    name: gateway-01
    mesh: default
    networking:
      address: "{{ ansible_facts.default_ipv4.address }}"
      gateway:
        tags:
          service: kong
    " | kumactl apply -f - --var ansible_facts.default_ipv4.address=127.0.0.1

    The command will fail with:

    Error: Could not create a resource (Resource is not valid)
    * networking.address: address has to be valid IP address
    

Additional Details & Logs

  • Version: 0.4.0
  • Platform and Operating System: MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants