-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(persistence): create pgx store #6359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
slonka
added
the
ci/run-full-matrix
PR: Runs all possible e2e test combination (expensive use carefully)
label
Mar 28, 2023
Signed-off-by: slonka <[email protected]>
6 tasks
Signed-off-by: slonka <[email protected]>
slonka
added
ci/skip-e2e-test
PR: Don't run e2e tests
and removed
ci/run-full-matrix
PR: Runs all possible e2e test combination (expensive use carefully)
labels
Mar 28, 2023
slonka
force-pushed
the
create-pgx-store
branch
from
March 28, 2023 15:08
4ed1fea
to
ce015b3
Compare
slonka
commented
Mar 28, 2023
slonka
commented
Mar 28, 2023
slonka
commented
Mar 28, 2023
slonka
commented
Mar 28, 2023
slonka
commented
Mar 28, 2023
slonka
force-pushed
the
create-pgx-store
branch
from
March 29, 2023 06:15
26ba487
to
4ed1fea
Compare
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
slonka
force-pushed
the
create-pgx-store
branch
from
March 29, 2023 06:33
4ed1fea
to
63d63b2
Compare
slonka
commented
Mar 29, 2023
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
…or pq configuration Signed-off-by: slonka <[email protected]>
slonka
force-pushed
the
create-pgx-store
branch
from
March 29, 2023 11:06
0f51454
to
5a769eb
Compare
slonka
commented
Mar 29, 2023
Signed-off-by: slonka <[email protected]>
slonka
force-pushed
the
create-pgx-store
branch
from
March 29, 2023 12:42
b71aed3
to
3e40c58
Compare
Signed-off-by: slonka <[email protected]>
slonka
force-pushed
the
create-pgx-store
branch
from
March 29, 2023 12:47
3e40c58
to
6744cd0
Compare
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
jakubdyszkiewicz
approved these changes
Mar 30, 2023
lahabana
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits
michaelbeaumont
approved these changes
Mar 30, 2023
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context()
in tests and that added indent so without "w=1" it shows a lot of code that did not actually change).There seems to be a weird behaviour in either
pool.Close()
/db.Close()
or postgres itself that it does not always close the connections. As a workaround I'm bumpingmax_connections
to 10k.Side note:
Closes #6363
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?