Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire in pc.AppContext() in postgres_plugin.go #6398

Closed
slonka opened this issue Mar 30, 2023 · 4 comments
Closed

Wire in pc.AppContext() in postgres_plugin.go #6398

slonka opened this issue Mar 30, 2023 · 4 comments
Assignees
@slonka
Labels
kind/improvement Improvement on an existing feature triage/rotten closed due to lack of information for too long, rejected feature...

Comments

@slonka
Copy link
Contributor

slonka commented Mar 30, 2023

Description

Improvement from PR: #6359 (comment)
@slonka slonka added triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Mar 30, 2023
@slonka slonka mentioned this issue Mar 30, 2023
Merged
6 tasks
@jakubdyszkiewicz
Copy link
Contributor

Triage: let's see how we close postgres pgx pool

@jakubdyszkiewicz jakubdyszkiewicz added triage/needs-reproducing Someone else should try to reproduce this and removed triage/pending This issue will be looked at on the next triage meeting labels Apr 3, 2023
@slonka slonka self-assigned this Apr 3, 2023
@bartsmykla
Copy link
Contributor

@slonka is it still an issue? How should we proceed with this?

@slonka
Copy link
Contributor Author

slonka commented May 19, 2023 •
edited
Loading

At 5:21 I deployed a new version of our control plane and we can see no drastic increase in active connections. So based on these metrics I conclude that we do not have a problem with pgx not closing connections on app shutdown.

image

@slonka slonka added triage/pending This issue will be looked at on the next triage meeting and removed triage/needs-reproducing Someone else should try to reproduce this labels May 19, 2023
@jakubdyszkiewicz
Copy link
Contributor

Triage: let's close it as it seems it does not cause any harm for now

@jakubdyszkiewicz jakubdyszkiewicz closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/rotten closed due to lack of information for too long, rejected feature... and removed triage/pending This issue will be looked at on the next triage meeting labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slonka slonka

Labels
kind/improvement Improvement on an existing feature triage/rotten closed due to lack of information for too long, rejected feature...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slonka @jakubdyszkiewicz @bartsmykla