feat(tproxy/cni): make tproxy v2 and CNI v2 default #6083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
+ fix one port which was out of uint16 bound Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
added
the
ci/run-full-matrix
|
/format |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Bart Smykla <[email protected]>
|
/format |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
requested review from
a team,
jakubdyszkiewicz and
Automaat
and removed request for
a team
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
changed the title
…v2-default Signed-off-by: Bart Smykla <[email protected]>
jakubdyszkiewicz
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make transparent proxy engine v2 and CNI v2 default
This PR temporary disables re-install transparent-proxy test as it basically never worked as expected. When we are installing tproxy again, it just adds the same set of rules after the existing ones (with small exception to DNS ones, but it's irrelevant here). So the tests were passing only because rules form the second installation had been just ignored.
When mechanism to uninstall tproxy will be implemented (ref. #6093), we will adapt this test to run the uninstaller step in between.
Closes: #5880
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? -- docs(UPGRADE.md): add section about tproxy/cni v2 #6135> Changelog:entry here or add aci/label to run fewer/more tests?