Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce logic to uninstall iptable rules #6093

Closed
bartsmykla opened this issue Apr 8, 2022 · 8 comments · Fixed by #10890
Closed

Introduce logic to uninstall iptable rules #6093

bartsmykla opened this issue Apr 8, 2022 · 8 comments · Fixed by #10890
Assignees
@bartsmykla
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.9.x

Comments

@bartsmykla
Copy link
Contributor

Description

We need logic to uninstall iptable rules with our new iptables transparent proxy engine
@bartsmykla bartsmykla added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Apr 8, 2022
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Apr 11, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 12, 2022
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jul 18, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 17, 2022
@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Oct 31, 2022
@bartsmykla
Copy link
Contributor Author

Currently by design, when installing tproxy we are saving all rules to the file, and then applying them bu using iptables-restore. To uninstall the rules, we probably would have to do it on per rule basis, as with my current understanding, we cannot do something like "remove all rules present in this or that file" or "before applying our rules, save the snapshot of the current ones to some file and restore it when uninstalling tproxy". In the first case I didn't find a way to do it, in the second one we are introducing the edge case of - what if the rules changes in the meantime? Which may seriously break the environment. By going with "per rule" approach we can also solve this issue: #6101 as we could not only uninstall the rules but also install them this way.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 20, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@bartsmykla bartsmykla transferred this issue from kumahq/kuma-net Feb 22, 2023
@github-actions github-actions bot added the triage/pending This issue will be looked at on the next triage meeting label Feb 22, 2023
@bartsmykla bartsmykla mentioned this issue Feb 23, 2023
Merged
6 tasks
@jakubdyszkiewicz jakubdyszkiewicz removed the triage/pending This issue will be looked at on the next triage meeting label Feb 27, 2023
@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Mar 1, 2023
@slonka
Copy link
Contributor

slonka commented Mar 1, 2023

@bartsmykla this is not yet done right?

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 31, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jun 12, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Sep 11, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Sep 11, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Dec 11, 2023
@lahabana lahabana modified the milestone: 2.6.x Jan 9, 2024
@lahabana lahabana added this to the 2.7.x milestone Jan 10, 2024
@lahabana lahabana modified the milestones: 2.7.x, 2.8.x Mar 27, 2024
@lahabana lahabana mentioned this issue Apr 10, 2024
Closed
@bartsmykla bartsmykla mentioned this issue May 7, 2024
Merged
5 tasks
@bartsmykla bartsmykla self-assigned this May 10, 2024
@lahabana lahabana modified the milestones: 2.8.x, 2.9.x Jun 3, 2024
@bartsmykla bartsmykla mentioned this issue Jul 14, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartsmykla bartsmykla

Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.9.x
Development

Successfully merging a pull request may close this issue.

feat(transparent-proxy): add option to uninstall transparent proxy kumahq/kuma
5 participants
@lahabana @slonka @jakubdyszkiewicz @bartsmykla @lukidzi