Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): change percentage field from int to intOrString #5810

Merged
merged 2 commits into from
Jan 23, 2023
Merged

fix(kuma-cp): change percentage field from int to intOrString #5810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e955217
fix(kuma-cp): change percentage field from int to intOrString
lukidzi Jan 23, 2023
b8b1407
fix(kuma-cp): fix check
lukidzi Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,13 @@ spec:
format: int32
type: integer
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which abort
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- httpStatus
- percentage
Expand All @@ -267,11 +269,13 @@ spec:
a response from a destination
properties:
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which delay
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
value:
description: The duration during which the response
will be delayed
Expand All @@ -289,11 +293,13 @@ spec:
in gbps, mbps, kbps or bps, e.g. 10kbps
type: string
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which response
bandwidth limit will be injected, has to be
in [0.0 - 100.0] range
format: int32
type: integer
bandwidth limit will be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- limit
- percentage
Expand Down Expand Up @@ -851,11 +857,14 @@ spec:
type: string
type: object
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: Allows to configure panic threshold for Envoy
cluster. If not specified, the default is 50%. To disable
panic mode, set to 0%.
format: int32
type: integer
panic mode, set to 0%. Either int or decimal represented
as string.
x-kubernetes-int-or-string: true
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
Expand Down
39 changes: 24 additions & 15 deletions app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present-not-enabled.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,13 @@ spec:
format: int32
type: integer
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which abort
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- httpStatus
- percentage
Expand All @@ -267,11 +269,13 @@ spec:
a response from a destination
properties:
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which delay
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
value:
description: The duration during which the response
will be delayed
Expand All @@ -289,11 +293,13 @@ spec:
in gbps, mbps, kbps or bps, e.g. 10kbps
type: string
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which response
bandwidth limit will be injected, has to be
in [0.0 - 100.0] range
format: int32
type: integer
bandwidth limit will be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- limit
- percentage
Expand Down Expand Up @@ -851,11 +857,14 @@ spec:
type: string
type: object
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: Allows to configure panic threshold for Envoy
cluster. If not specified, the default is 50%. To disable
panic mode, set to 0%.
format: int32
type: integer
panic mode, set to 0%. Either int or decimal represented
as string.
x-kubernetes-int-or-string: true
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
Expand Down
39 changes: 24 additions & 15 deletions app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,13 @@ spec:
format: int32
type: integer
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which abort
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- httpStatus
- percentage
Expand All @@ -267,11 +269,13 @@ spec:
a response from a destination
properties:
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which delay
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
value:
description: The duration during which the response
will be delayed
Expand All @@ -289,11 +293,13 @@ spec:
in gbps, mbps, kbps or bps, e.g. 10kbps
type: string
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which response
bandwidth limit will be injected, has to be
in [0.0 - 100.0] range
format: int32
type: integer
bandwidth limit will be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- limit
- percentage
Expand Down Expand Up @@ -1003,11 +1009,14 @@ spec:
type: string
type: object
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: Allows to configure panic threshold for Envoy
cluster. If not specified, the default is 50%. To disable
panic mode, set to 0%.
format: int32
type: integer
panic mode, set to 0%. Either int or decimal represented
as string.
x-kubernetes-int-or-string: true
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
Expand Down
39 changes: 24 additions & 15 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,11 +273,13 @@ spec:
format: int32
type: integer
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which abort
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- httpStatus
- percentage
Expand All @@ -287,11 +289,13 @@ spec:
a response from a destination
properties:
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which delay
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
value:
description: The duration during which the response
will be delayed
Expand All @@ -309,11 +313,13 @@ spec:
in gbps, mbps, kbps or bps, e.g. 10kbps
type: string
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which response
bandwidth limit will be injected, has to be
in [0.0 - 100.0] range
format: int32
type: integer
bandwidth limit will be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- limit
- percentage
Expand Down Expand Up @@ -871,11 +877,14 @@ spec:
type: string
type: object
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: Allows to configure panic threshold for Envoy
cluster. If not specified, the default is 50%. To disable
panic mode, set to 0%.
format: int32
type: integer
panic mode, set to 0%. Either int or decimal represented
as string.
x-kubernetes-int-or-string: true
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
Expand Down
39 changes: 24 additions & 15 deletions app/kumactl/cmd/install/testdata/install-crds.all.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,11 +1424,13 @@ spec:
format: int32
type: integer
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which abort
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- httpStatus
- percentage
Expand All @@ -1438,11 +1440,13 @@ spec:
a response from a destination
properties:
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which delay
will be injected, has to be in [0.0 - 100.0]
range
format: int32
type: integer
will be injected, has to be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
value:
description: The duration during which the response
will be delayed
Expand All @@ -1460,11 +1464,13 @@ spec:
in gbps, mbps, kbps or bps, e.g. 10kbps
type: string
percentage:
anyOf:
- type: integer
- type: string
description: Percentage of requests on which response
bandwidth limit will be injected, has to be
in [0.0 - 100.0] range
format: int32
type: integer
bandwidth limit will be either int or decimal
represented as string.
x-kubernetes-int-or-string: true
required:
- limit
- percentage
Expand Down Expand Up @@ -2022,11 +2028,14 @@ spec:
type: string
type: object
healthyPanicThreshold:
anyOf:
- type: integer
- type: string
description: Allows to configure panic threshold for Envoy
cluster. If not specified, the default is 50%. To disable
panic mode, set to 0%.
format: int32
type: integer
panic mode, set to 0%. Either int or decimal represented
as string.
x-kubernetes-int-or-string: true
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
Expand Down
Loading