Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): change percentage field from int to intOrString #5810

Merged
merged 2 commits into from
Jan 23, 2023
Merged

fix(kuma-cp): change percentage field from int to intOrString #5810

merged 2 commits into from
Jan 23, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jan 23, 2023 •
edited by lahabana
Loading

Replace the percentage field accepting only int with intOrString.

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: fix(policy): change percentage field from int to intOrString

@lukidzi lukidzi marked this pull request as ready for review January 23, 2023 13:30
@lukidzi lukidzi requested review from a team, bartsmykla and lobkovilya and removed request for a team January 23, 2023 13:30
@lukidzi lukidzi merged commit 432ff2e into kumahq:master Jan 23, 2023
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukidzi @jakubdyszkiewicz