feat(kuma-cp) validate traffic permission #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
approved these changes
Nov 14, 2019
| permission string | ||
| expected string | ||
| } | ||
| DescribeTable("should validate all fields and return as much individual erorrs as possible", |
jakubdyszkiewicz
force-pushed
the
feature/traffic-permission-validator
branch
from
c0a9cd6
to
267d956
Compare
jakubdyszkiewicz
changed the base branch from
feature/traffic-permission-one-rule
to
master
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Validate traffic permission. Only service tag is allowed in both cases for now.
Once this is merged, I'll fix the TrafficLog to also use
OnlyServiceTagAllowed