Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): add uptime, policies, gateway dps to reports #3933

Merged
merged 8 commits into from
Mar 3, 2022

Conversation

parkanzky
Copy link
Contributor

@parkanzky parkanzky commented Feb 25, 2022

Signed-off-by: Paul Parkanzky [email protected]

Summary

Add uptime of CP and number of policies and gateway DPs to reports.

I won't merge this without testing, but I'm not sure how to do that. Any advice is appreciated.

Full changelog

  • Add Kuma CP uptime, number of gateways and policy info to reports.

Issues resolved

Fix #436

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@parkanzky parkanzky requested a review from a team as a code owner February 25, 2022 17:59
Paul Parkanzky added 2 commits February 25, 2022 13:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2022

Codecov Report

Merging #3933 (90604f5) into master (c5c81cb) will decrease coverage by 0.00%.
The diff coverage is 39.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
- Coverage   56.04%   56.03%   -0.01%     
==========================================
  Files         911      911              
  Lines       54303    54348      +45     
==========================================
+ Hits        30435    30455      +20     
- Misses      21417    21448      +31     
+ Partials     2451     2445       -6     
Impacted Files Coverage Δ
pkg/test/runtime/runtime.go 85.29% <0.00%> (-2.59%) ⬇️
pkg/core/runtime/reports/reports.go 9.79% <2.63%> (-2.83%) ⬇️
pkg/core/runtime/runtime.go 81.25% <50.00%> (-2.09%) ⬇️
pkg/core/runtime/builder.go 62.72% <83.87%> (-1.13%) ⬇️
pkg/core/bootstrap/bootstrap.go 66.66% <100.00%> (ø)
pkg/api-server/server.go 85.35% <0.00%> (-2.93%) ⬇️
pkg/plugins/resources/postgres/store.go 75.10% <0.00%> (+0.42%) ⬆️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 88.76% <0.00%> (+1.12%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c81cb...90604f5. Read the comment docs.

pkg/core/runtime/runtime.go Outdated Show resolved Hide resolved
pkg/core/runtime/reports/reports.go Outdated Show resolved Hide resolved
pkg/core/runtime/reports/reports.go Show resolved Hide resolved
@parkanzky parkanzky merged commit 5b93b1b into master Mar 3, 2022
@parkanzky parkanzky deleted the feat/add-reporting-metrics branch March 3, 2022 15:51
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants