fix(kds): clone resource on update meta (backport of #10460) #12122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kumahq[bot]](https://avatars.githubusercontent.com/u/67433617?s=60&v=4){kind=small}
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
kumahq
bot
requested review from
jijiechen and
slonka
and removed request for
a team
Signed-off-by: Lukasz Dziedziak <[email protected]>
|
While investigating the KDS code in the unexpected fault address 0x0
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x80 addr=0x0 pc=0x1538f3b]
goroutine 5145 gp=0xc001cb5180 m=4 mp=0xc000100008 [running]:
...
github.com/kumahq/kuma/pkg/kds/context.DefaultContext.UpdateResourceMeta.func2(0xc0032183c0?, {0x4874b50, 0xc0013ff0e0})goroutine 45485 gp=0xc001005880 m=nil [runnable]:
...
github.com/kumahq/kuma/pkg/kds/context.DefaultContext.If.func15(0xc0047cb8c0, {0x4874b50, 0xc0016fbbd8})in both goroutine |
Automaat
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the KDS code in the
release-2.7branch, I noticed that the resource is not cloned inUpdateResourceMeta. This issue was fixed in releases >= 2.8, but it remains unresolved in 2.7. I'm not sure if the fix fully addresses the issue, but it seems relatedin both goroutine
0x4874b50is the meta address.Automatic cherry-pick of #10460 for branch release-2.7
Generated by action
cherry-picked commit 3d506ed