fix(kds): clone resource on update meta #10460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
requested review from
Automaat and
lobkovilya
and removed request for
a team
michaelbeaumont
approved these changes
Jun 13, 2024
kumahq bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
This was referenced Nov 27, 2024
lahabana
pushed a commit
that referenced
this pull request
Nov 27, 2024
While investigating the KDS code in the `release-2.7` branch, I noticed
that the resource is not cloned in `UpdateResourceMeta`. This issue was
fixed in releases >= 2.8, but it remains unresolved in 2.7. I'm not sure
if the fix fully addresses the issue, but it seems related
```yaml
unexpected fault address 0x0
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x80 addr=0x0 pc=0x1538f3b]
goroutine 5145 gp=0xc001cb5180 m=4 mp=0xc000100008 [running]:
...
github.com/kumahq/kuma/pkg/kds/context.DefaultContext.UpdateResourceMeta.func2(0xc0032183c0?, {0x4874b50, 0xc0013ff0e0})
```
```yaml
goroutine 45485 gp=0xc001005880 m=nil [runnable]:
...
github.com/kumahq/kuma/pkg/kds/context.DefaultContext.If.func15(0xc0047cb8c0, {0x4874b50, 0xc0016fbbd8})
```
in both goroutine `0x4874b50` is the meta address.
Automatic cherry-pick of #10460 for branch release-2.7
Generated by
[action](https://github.com/kumahq/kuma/actions/runs/12051462482)
cherry-picked commit 3d506ed
---------
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Jakub Dyszkiewicz <[email protected]>
Co-authored-by: Lukasz Dziedziak <[email protected]>
lukidzi
added a commit
that referenced
this pull request
Nov 27, 2024
While investigating the KDS code in the `release-2.6` branch, I noticed
that the resource is not cloned in `UpdateResourceMeta`. This issue was
fixed in releases >= 2.8, but it remains unresolved in 2.6. I'm not sure
if the fix fully addresses the issue, but it seems related
```yaml
unexpected fault address 0x0
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x80 addr=0x0 pc=0x1538f3b]
goroutine 5145 gp=0xc001cb5180 m=4 mp=0xc000100008 [running]:
...
github.com/kumahq/kuma/pkg/kds/context.DefaultContext.UpdateResourceMeta.func2(0xc0032183c0?, {0x4874b50, 0xc0013ff0e0})
```
```yaml
goroutine 45485 gp=0xc001005880 m=nil [runnable]:
...
github.com/kumahq/kuma/pkg/kds/context.DefaultContext.If.func15(0xc0047cb8c0, {0x4874b50, 0xc0016fbbd8})
```
in both goroutine `0x4874b50` is the meta address.
Automatic cherry-pick of #10460 for branch release-2.6
Generated by
[action](https://github.com/kumahq/kuma/actions/runs/12051462482)
cherry-picked commit 3d506ed
---------
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Jakub Dyszkiewicz <[email protected]>
Co-authored-by: Lukasz Dziedziak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
While this is a "bug" it was not a problem for the current code, because we never update synced resource.
I only discovered this after I added a component that takes synced resource from cached resource manager and tries to update it. The meta was wrong, because it was replaced on the cached resource.
xref #9031
No need to backport.
syscall.Mkfifohave equivalent implementation on the other OS --ci/labels to run additional/fewer testsUPGRADE.md? --