Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isNewStylePolicy field to /policies #7485

Closed
kleinfreund opened this issue Aug 7, 2023 · 2 comments · Fixed by #7561
Closed

Add isNewStylePolicy field to /policies #7485

kleinfreund opened this issue Aug 7, 2023 · 2 comments · Fixed by #7561
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@kleinfreund
Copy link
Contributor

Description

Add a isNewStylePolicy field to /policies indicating whether a policy type is of a new style. We specifically want this for kumahq/kuma-gui#1290 meaning what we want to be able to do is know whether a policy of a certain policy type will have a top-level target ref object.
@kleinfreund kleinfreund added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Aug 7, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Aug 7, 2023
@kleinfreund kleinfreund mentioned this issue Aug 21, 2023
Merged
@lahabana
Copy link
Contributor

Will be isTargetRefBased

lahabana added a commit that referenced this issue Aug 22, 2023
@lahabana
feat(api-server): add isTargetRefBased in /policies
242a31e 
This is useful in the GUI

fix #7485

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana mentioned this issue Aug 22, 2023
Merged
6 tasks
@lahabana
Copy link
Contributor

Will also add isInbound and isOutbound as its useful.

lahabana added a commit that referenced this issue Aug 24, 2023
@lahabana
feat(api-server): add isTargetRefBased in /policies (#7561)
389685b 
* feat(api-server): add isTargetRefBased in /policies

This is useful in the GUI

fix #7485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api-server): add isTargetRefBased in /policies kumahq/kuma
3 participants
@lahabana @jakubdyszkiewicz @kleinfreund