Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-server): add isTargetRefBased in /policies #7561

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

lahabana
Copy link
Contributor

This is useful in the GUI

fix #7485

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

This is useful in the GUI

fix #7485

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested a review from a team as a code owner August 22, 2023 11:39
@lahabana lahabana requested review from michaelbeaumont and jakubdyszkiewicz and removed request for a team August 22, 2023 11:39
@lahabana
Copy link
Contributor Author

@kleinfreund FYI

@lahabana lahabana merged commit 389685b into master Aug 24, 2023
5 checks passed
@lahabana lahabana deleted the fix7485 branch August 24, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isNewStylePolicy field to /policies
5 participants