Add docs for limits/requests, affinity, reword PDB #393
Conversation
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
✅ Deploy Preview for silly-bunny-8cedd0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
viccuad
changed the title
Co-authored-by: John Krug <[email protected]> Signed-off-by: Víctor Cuadrado Juan <[email protected]>
There was a problem hiding this comment.
A few more small typos.
It's not strictly necessary to have a 'sidebar_position' in the front matter, but I'd recommend it so it doesn't get shifted about if additional content files are added.
Also, a _category.json in the new policy-servers directory is a good idea for the same reason. Its 'label' field fixes a position in the howto level.
Otherwise, LGTM!
Co-authored-by: John Krug <[email protected]> Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
|
Thanks for the review! Added |
| ] | ||
| --- | ||
|
|
||
| PolicyServers are critical to the cluster. Reliability of them is important as |
There was a problem hiding this comment.
We should have some guidelines about how to spell certain pieces of our tech stack. Do we have to use PolicyServer or Policy Server?
It would be even better to have some keywords that automatically expand to the right term. For example, &policyServer gets expanded to be PolicyServer at rendering time. I don't know if docusaurus has something for that
CC @jhkrug
There was a problem hiding this comment.
I think we have agreed on PolicyServer, where talking about the component in general. As per the Kubernetes docs style guide. And yes, I can do something about variables in DS. I had to do it for Longhorn. It would be something like
[[< policy-server-component >]] expands to PolicyServer, etc.
There was a problem hiding this comment.
Opened #394 to not forget about it, please feel free to edit it.
Co-authored-by: Flavio Castelli <[email protected]> Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Description
Fix kubewarden/kubewarden-controller#703
Test
Additional Information
Tradeoff
Potential improvement