Bump device-plugin-manager and kubelet deps #30
Conversation
kubevirt-bot
added
dco-signoff: yes
cluster/up.sh
Outdated
| @@ -5,7 +5,7 @@ set -ex | |||
| source ./cluster/kubevirtci.sh | |||
| kubevirtci::install | |||
|
|
|||
| $(kubevirtci::path)/cluster-up/up.sh | |||
| $(kubevirtci::path)/cluster-up/up.sh || $(kubevirtci::path)/cluster-up/kubectl.sh get networkaddonsconfig cluster -o yaml | |||
There was a problem hiding this comment.
The "print" would silence the error here. So setup would continue even after we failed to set it up.
I also think that we could keep the print on the problematic command - on the wait. I don't think it would make sense for other issues that can happen inside "up"
There was a problem hiding this comment.
Hmm, you're correct about the error being silenced...
As I mentioned before, the wait command does not reside in this repository, it's one of the first two in the following output:
~/Sources/macvtap-cni # grep -R kubectl | grep wait
**_kubevirtci/cluster-provision/k8s-multus/scripts/node01.sh:kubectl --kubeconfig=/etc/kubernetes/admin.conf wait networkaddonsconfig cluster --for condition=Ready --timeout=800s**
**_kubevirtci/cluster-provision/k8s-multus/scripts/provision.sh:kubectl --kubeconfig=/etc/kubernetes/admin.conf wait networkaddonsconfig cluster --for condition=Ready --timeout=800s**
_kubevirtci/cluster-up/cluster/kind/common.sh: _kubectl wait -n kube-system --timeout=12m --for=condition=Ready -l k8s-app=kube-dns pods
_kubevirtci/cluster-up/cluster/kind/common.sh: _kubectl wait --for=condition=Ready pod --all -n kube-system --timeout 12m
_kubevirtci/cluster-up/cluster/kind-k8s-sriov-1.14.2/config_sriov.sh:# not using kubectl wait since with the sriov operator the pods get restarted a couple of times and this is
It's being run from _kubevirtci witch is git cloned at cluster/up.sh runtime.
There was a problem hiding this comment.
Oh, I'm so sorry for missing that. I though we are creating CNAO here directly. My bad.
In that case, the debug output should go to https://github.com/kubevirt/kubevirtci
Could we limit this PR only to the bump.
There was a problem hiding this comment.
No problem, removed that commit from this PR
|
/hold Need to take a look at this; we've been too trigger happy in this repo in the past. |
kubevirt-bot
added
the
do-not-merge/hold
rhrazdil
force-pushed
the
print_nac_if_up_fails
branch
from
7b0ac30 to
edc2bfb
Compare
rhrazdil
changed the title
|
/lgtm Thanks! Let's hear from Mr. @maiqueb |
rhrazdil
force-pushed
the
print_nac_if_up_fails
branch
from
edc2bfb to
cf8c15c
Compare
rhrazdil
force-pushed
the
print_nac_if_up_fails
branch
2 times, most recently
from
812d345 to
792e1cd
Compare
Bump Device Plugin Manager and kubelet. New kubelet version requires dpm.PluginInterface to implement GetPreferredAllocation function. Signed-off-by: Radim Hrazdil <[email protected]>
Run make vendor to update vendored packages. Signed-off-by: Radim Hrazdil <[email protected]>
rhrazdil
force-pushed
the
print_nac_if_up_fails
branch
from
792e1cd to
83d466c
Compare
|
Thanks |
kubevirt-bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek, rhrazdil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
approved
kubevirt-bot
removed
the
do-not-merge/release-note-label-needed
Signed-off-by: Radim Hrazdil [email protected]
What this PR does / why we need it:
A followup to ubruptly merged PR #29
Printing clusternetworkaddons CR when cluster-up fails to provide debug info.
Bumping last dependencies device-plugin-manager and k8s.io/kubelet to v0.19.1
New kubelet version requires
dpm.PluginInterfaceto implementGetPreferredAllocationfunction.Added implementation returns
nilas a list of preffered devices, which should keep the original behaviour [0][0] https://github.com/kubernetes/kubernetes/pull/92665/files#diff-b54ee8195220ea88e59b6eb423e83dd1R741
Special notes for your reviewer:
Release note