Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies #29

Merged
merged 9 commits into from
Sep 17, 2020
Merged

Bump dependencies #29

merged 9 commits into from
Sep 17, 2020

Conversation

rhrazdil
Copy link
Contributor

@rhrazdil rhrazdil commented Sep 16, 2020 •
edited
Loading

Bump dependencies.

What this PR does / why we need it:

Special notes for your reviewer:

When trying to use k8s.io/kubelet v0.19.1, make check fails on

pkg/deviceplugin/lister.go:168:31: cannot use NewMacvtapDevicePlugin(c.Name, c.Master, c.Mode, c.Capacity, ml.NetNsPath) (type *macvtapDevicePlugin) as type dpm.PluginInterface in return argument:
	*macvtapDevicePlugin does not implement dpm.PluginInterface (missing GetPreferredAllocation method)

which is why I'm currently sticking with an older k8s.io/kubelet v0.18.8

Release Note

Bump github.com/aktau/github-release to v0.8.1
Bump github.com/containernetworking/cni to v0.8.0
Bump kubernetes packages to v1.19.1

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 16, 2020
@rhrazdil rhrazdil force-pushed the bump_dependencies branch 2 times, most recently from 3082fbf to 0323535 Compare September 16, 2020 12:31
Radim Hrazdil added 2 commits September 16, 2020 14:40
Bump kubernetes to v0.19.1
5f972ba 
Signed-off-by: Radim Hrazdil <[email protected]>
make vendor for new go.mod
fca80cb 
Signed-off-by: Radim Hrazdil <[email protected]>
@rhrazdil rhrazdil changed the title WIP Bump dependencies Bump dependencies Sep 16, 2020
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2020
Radim Hrazdil added 4 commits September 16, 2020 16:25
adjust e2e tests to client-go 1.18
7ab0f7b 
Signed-off-by: Radim Hrazdil <[email protected]>
Fix test verbose flag setting
d7bd235 
Signed-off-by: Radim Hrazdil <[email protected]>
Flags should be parsed in BeforeSuite
0e45035 
Test run otherwise fails due to unrecognized arguments

Signed-off-by: Radim Hrazdil <[email protected]>
Update manifests based on new template
08934da 
This is a followup to PR kubevirt#27 [0]

[0] kubevirt#27

Signed-off-by: Radim Hrazdil <[email protected]>
phoracek
phoracek reviewed Sep 16, 2020
View reviewed changes
go.mod
k8s.io/api v0.19.1
k8s.io/apimachinery v0.19.1
k8s.io/client-go v0.19.1
k8s.io/kubelet v0.18.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is kubelet older than kubernetes here? And why is it required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deviceplugin has moved under kubelet
With v0.19.1 there is an error:

pkg/deviceplugin/lister.go:168:31: cannot use NewMacvtapDevicePlugin(c.Name, c.Master, c.Mode, c.Capacity, ml.NetNsPath) (type *macvtapDevicePlugin) as type dpm.PluginInterface in return argument:
	*macvtapDevicePlugin does not implement dpm.PluginInterface (missing GetPreferredAllocation method)

Probably related to device scheduler in 1.19.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puff, we may need to bump that on device-plugin-manager repo... But that can wait for a follow-up, let's not get even deeper into this. Ack, thanks

@rhrazdil rhrazdil force-pushed the bump_dependencies branch 2 times, most recently from 39105e5 to a22dfc9 Compare September 17, 2020 07:25
@rhrazdil
Copy link
Contributor Author

/retest

Bump Go version to 1.13
fe13662 
Signed-off-by: Radim Hrazdil <[email protected]>
phoracek
phoracek approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Let's hear from @maiqueb too

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@kubevirt-bot kubevirt-bot merged commit 5557681 into kubevirt:master Sep 17, 2020
@phoracek
Copy link
Member

Or not, where did that approve came from -_-

@maiqueb
Copy link
Collaborator

maiqueb commented Sep 17, 2020

Yeah, something is awfully wrong here.

From the bot's words, I can see that the PR has been auto-approved by whoever proposed it - #29 (comment)

That wrong on so many levels ...

@phoracek please remember that until we fix this mess, you gotta hold if you want more inputs.

@phoracek
Copy link
Member

Hold my hand 🦆 /\ 🦆

@rhrazdil rhrazdil mentioned this pull request Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhrazdil @kubevirt-bot @phoracek @maiqueb