Fix container command quotes in macvtap.yaml.in #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: no
rhrazdil
force-pushed
the
fix_command_quotes
branch
from
a6b4659 to
28b96de
Compare
kubevirt-bot
added
dco-signoff: yes
|
The commit message is missing the why |
rhrazdil
force-pushed
the
fix_command_quotes
branch
from
28b96de to
0c356b6
Compare
Use double quotes instead of single quotes in: command: ['cp', '/macvtap-cni', '/host/opt/cni/bin/macvtap'] because we are using single quotes around template variables and having single quotes in the above command list blocks us from using simple sed to remove all single quotes in the entire yaml template. Signed-off-by: Radim Hrazdil <[email protected]>
rhrazdil
force-pushed
the
fix_command_quotes
branch
from
0c356b6 to
4adfdef
Compare
|
@phoracek Updated commit message |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek, rhrazdil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/release-note-none |
kubevirt-bot
added
release-note-none
rhrazdil
pushed a commit
to rhrazdil/cluster-network-addons-operator
that referenced
this pull request
Sep 10, 2020
It contains the following PRs:
- Change vbom.ml/util dependency with github.com/fvbommel/util [0]
Fixes vbom dependency
- Adding quotes in macvtap.yaml.in [1]
Allows using yq to edit macvtap.yaml.in
- Fix container command quotes in macvtap.yaml.in [2]
Fixes single quotes in command list
[0] kubevirt/macvtap-cni#25
[1] kubevirt/macvtap-cni#24
[2] kubevirt/macvtap-cni#27
Signed-off-by: Radim Hrazdil <[email protected]>
kubevirt-bot
pushed a commit
to kubevirt/cluster-network-addons-operator
that referenced
this pull request
Sep 10, 2020
* Bump macvtap dep to v0.3.1
It contains the following PRs:
- Change vbom.ml/util dependency with github.com/fvbommel/util [0]
Fixes vbom dependency
- Adding quotes in macvtap.yaml.in [1]
Allows using yq to edit macvtap.yaml.in
- Fix container command quotes in macvtap.yaml.in [2]
Fixes single quotes in command list
[0] kubevirt/macvtap-cni#25
[1] kubevirt/macvtap-cni#24
[2] kubevirt/macvtap-cni#27
Signed-off-by: Radim Hrazdil <[email protected]>
* Add PlacementConfiguration for macvtap
Use Workloads PlacementConfiguration from NetworkAddonsConfig in macvtap pods.
By default, macvtap pods will be scheduled on all nodes.
Signed-off-by: Radim Hrazdil <[email protected]>
rhrazdil
pushed a commit
to rhrazdil/macvtap-cni
that referenced
this pull request
Sep 16, 2020
This is a followup to PR kubevirt#27 [0] [0] kubevirt#27 Signed-off-by: Radim Hrazdil <[email protected]>
kubevirt-bot
pushed a commit
that referenced
this pull request
Sep 17, 2020
* Bump github.com/aktau/github-release to v0.8.1 Signed-off-by: Radim Hrazdil <[email protected]> * Bump github.com/containernetworking/cni to v0.8.0 Signed-off-by: Radim Hrazdil <[email protected]> * Bump kubernetes to v0.19.1 Signed-off-by: Radim Hrazdil <[email protected]> * make vendor for new go.mod Signed-off-by: Radim Hrazdil <[email protected]> * adjust e2e tests to client-go 1.18 Signed-off-by: Radim Hrazdil <[email protected]> * Fix test verbose flag setting Signed-off-by: Radim Hrazdil <[email protected]> * Flags should be parsed in BeforeSuite Test run otherwise fails due to unrecognized arguments Signed-off-by: Radim Hrazdil <[email protected]> * Update manifests based on new template This is a followup to PR #27 [0] [0] #27 Signed-off-by: Radim Hrazdil <[email protected]> * Bump Go version to 1.13 Signed-off-by: Radim Hrazdil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use double quotes instead of single quotes in:
command: ["cp", "/macvtap-cni", "/host/opt/cni/bin/macvtap"]
What this PR does / why we need it:
Special notes for your reviewer:
Release notes: