Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify template manifest #20

Merged
merged 3 commits into from
Mar 13, 2020

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Mar 13, 2020

What this PR does / why we need it:
Adds required information to the templates, so it can be added to CNAO.

  • image pull policy
  • namespace

Also add a security context constraint, which is mandatory for OKD.

maiqueb added 3 commits March 13, 2020 18:10
The following attributes were added:
  - namespace info to metadata
  - image pull policy to running container
  - CPU / memory requests to running container

Also simplify the manifest - e.g. container image - so it can be
easily imported by CNAO.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
This template and generated manifest are paramount to deploy in
OKD, where an SCC is required to be able to run a privileged
container.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2020
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2020
@maiqueb
Copy link
Collaborator Author

maiqueb commented Mar 13, 2020

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2020
@phoracek
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@kubevirt-bot kubevirt-bot merged commit 5bf0c10 into kubevirt:master Mar 13, 2020
@maiqueb maiqueb deleted the unify_template_manifest branch May 17, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants