Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make components macvtap #348

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Make components macvtap #348

merged 2 commits into from
Mar 18, 2020

Conversation

maiqueb
Copy link
Contributor

@maiqueb maiqueb commented Mar 13, 2020

Automate macvtap component generation.

By doing make components, the specified version of macvtap-cni is cloned, and it's manifests copied, becoming available as CNAO provisioning files.

Depends-on: #346
Depends-on: kubevirt/macvtap-cni#20

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2020
@kubevirt-bot kubevirt-bot requested review from phoracek and qinqon March 13, 2020 17:33
@maiqueb
Copy link
Contributor Author

maiqueb commented Mar 13, 2020

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2020
phoracek
phoracek requested changes Mar 13, 2020
View reviewed changes
components.yaml Outdated Show resolved Hide resolved
hack/components.sh Outdated Show resolved Hide resolved
@maiqueb maiqueb force-pushed the make_components_macvtap branch 2 times, most recently from f5ca1a0 to 22c752d Compare March 16, 2020 14:47
@maiqueb maiqueb requested a review from phoracek March 16, 2020 14:48
@maiqueb
Add macvtap-cni component
6c38230 
Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb maiqueb force-pushed the make_components_macvtap branch from 22c752d to 5e5328d Compare March 17, 2020 11:31
phoracek
phoracek requested changes Mar 17, 2020
View reviewed changes
hack/components.sh Outdated
# TODO: uncomment the following lines *once* there is macvtap upgrade is supported
#MACVTAP_IMAGE=quay.io/kubevirt/macvtap-cni
#MACVTAP_IMAGE_TAGGED=${MACVTAP_IMAGE}:${MACVTAP_TAG}
#sed -i "s#\"${MACVTAP_IMAGE}:.*\"#\"${MACVTAP_IMAGE_TAGGED}\"#" pkg/components/components.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be still active. components.go bump the defaults (so image value used in the generated manifests). Only the following line is related to upgrade tests.

@maiqueb maiqueb force-pushed the make_components_macvtap branch from 5e5328d to 32c48c7 Compare March 18, 2020 08:00
@maiqueb maiqueb requested a review from phoracek March 18, 2020 08:25
@phoracek
Copy link
Member

/lgtm
/approve

Looking forward to test it with 0.2!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@phoracek
Copy link
Member

/override pull-e2e-cluster-network-addons-operator-workflow-k8s

@kubevirt-bot
Copy link
Collaborator

@phoracek: Overrode contexts on behalf of phoracek: pull-e2e-cluster-network-addons-operator-workflow-k8s

In response to this:

/override pull-e2e-cluster-network-addons-operator-workflow-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 81d5a68 into kubevirt:master Mar 18, 2020
@kubevirt-bot
Copy link
Collaborator

@maiqueb: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-e2e-cluster-network-addons-operator-workflow-k8s 32c48c7 link /test pull-e2e-cluster-network-addons-operator-workflow-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon Awaiting requested review from qinqon

@phoracek phoracek Awaiting requested review from phoracek

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maiqueb @phoracek @kubevirt-bot