Add check-cluster-up script for KinD providers #645

ormergi · 2021-07-18T16:17:40Z

Currently we dont run Kubevirt conformance tests on SR-IOV check up lane
This PR adds check-cluster-up script for KinD based providers, similar to what we have on check-provision lanes.

Basically it will check that the cluster is healthy, dump the nodes network configurations
and run conformance tests.

This script will be used on SR-IOV prow job command in order to prevent bad changes to SR-IOV provider.

Signed-off-by: Or Mergi [email protected]

Signed-off-by: Or Mergi <[email protected]>

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

Signed-off-by: Or Mergi <[email protected]>

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

Signed-off-by: Or Mergi <[email protected]>

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

oshoval · 2021-08-09T09:19:06Z

This PR check-cluster-up script for KinD based providers, similar to what we have on check-provision lanes.

Missing the word adds

oshoval

Thanks

cluster-up/cluster/kind/check-cluster-up.sh

oshoval · 2021-08-09T09:24:12Z

cluster-up/cluster/kind/check-cluster-up.sh

+    latest=$(curl -L "${nightly_build_base_url}/latest")
+
+    echo "Deploy latest nighly build Kubevirt"
+    if [ $(kubectl get kubevirts -n kubevirt kubevirt -ojsonpath='{.status.phase}') != "Deployed"; then


maybe worth to assert that kubevirt is not deployed instead ?
i do understand it gives freedom to install specific kubevirt, so up to you

btw usually on kubevirtci the sonobuoy conformance are without kubevirt, right?

maybe worth to assert that kubevirt is not deployed instead ?
i do understand it gives freedom to install specific kubevirt, so up to you

In case its not deployed it wont get into the if block

btw usually on kubevirtci the sonobuoy conformance are without kubevirt, right?

Currently we run Kubevirt conformance as well on all check-provision lanes

oshoval · 2021-08-09T09:25:09Z

cluster-up/cluster/kind/check-cluster-up.sh

+      ${kubectl} apply -f "${nightly_build_base_url}/${latest}/kubevirt-operator.yaml"
+      ${kubectl} apply -f "${nightly_build_base_url}/${latest}/kubevirt-cr.yaml"
+    fi
+    ${kubectl} wait -n kubevirt kv kubevirt --for condition=Available --timeout 15m


maybe should be part of the if, else it means that the kubevirt is deployed but here you are checking that its also Available, again up to you

This check is not part of the if in order to prevent running tests in case not all kubevirt components are ready.

maybe 15 minutes is too much ?
how much other repos use

on hack/cluster-deploy.sh it check every 5 minutes for 25 minutes
https://github.com/kubevirt/kubevirt/blob/371958b07a340d0ba9e9d1e9a2936411e395a5df/hack/cluster-deploy.sh#L154
From what I saw sometime it takes 2-3 rounds to be ready, rarely more then 10 minutes , so I picked 15 minutes timeout.

cluster-up/cluster/kind/check-cluster-up.sh

ormergi · 2021-08-16T08:21:41Z

/retest

oshoval · 2021-08-16T08:53:33Z

the last push is pure rebase right ?

ormergi · 2021-08-16T08:59:58Z

the last push is pure rebase right ?

Yes

oshoval

Thanks

dhiller

/approve

Sorry for the delay, this slipped through :-/

kubevirt-bot · 2021-09-06T13:08:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dhiller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ormergi · 2021-09-09T06:42:32Z

/hold

Wait until kubevirt/kubevirt#6199 is merged as we might need to do some changes to this PR

ormergi · 2021-10-19T15:45:31Z

/unhold

ormergi · 2021-10-19T15:45:57Z

/retest

kubevirt-commenter-bot · 2021-10-19T20:11:32Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot · 2021-10-20T03:11:33Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[5a10f48 Add check-cluster-up script for KinD providers](kubevirt/kubevirtci#645) Signed-off-by: kubevirt-bot <[email protected]>

[bf9b729 Upgrade SR-IOV provider nodes image to k8s-1.22](kubevirt/kubevirtci#694) [5a10f48 Add check-cluster-up script for KinD providers](kubevirt/kubevirtci#645) Signed-off-by: kubevirt-bot <[email protected]>

[8198e9c sync provider.sh between kind and kind-sriov](kubevirt/kubevirtci#587) [8b1d599 Restore kind-1.19-sriov provider files](kubevirt/kubevirtci#695) [bf9b729 Upgrade SR-IOV provider nodes image to k8s-1.22](kubevirt/kubevirtci#694) [5a10f48 Add check-cluster-up script for KinD providers](kubevirt/kubevirtci#645) Signed-off-by: kubevirt-bot <[email protected]>

kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 18, 2021

kubevirt-bot requested review from jean-edouard and oshoval July 18, 2021 16:17

kubevirt-bot added the size/L label Jul 18, 2021

ormergi mentioned this pull request Jul 18, 2021

Run Kubevirt conformance tests on check-up SR-IOV lane kubevirt/project-infra#1453

Merged

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 18, 2021

Fetch kubevirt/kubevirtci#645 changes

fb40787

Signed-off-by: Or Mergi <[email protected]>

ormergi mentioned this pull request Jul 18, 2021

test #1453 with kubevirt/kubevirtci#645 kubevirt/project-infra#1454

Closed

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 18, 2021

Fetch kubevirt/kubevirtci#645 changes

d268e14

Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 19, 2021

Fetch kubevirt/kubevirtci#645 changes

5399286

Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 19, 2021

Fetch kubevirt/kubevirtci#645 changes

d75b0b7

Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 19, 2021

Fetch kubevirt/kubevirtci#645 changes

0baa44b

Signed-off-by: Or Mergi <[email protected]>

ormergi force-pushed the sriov-lane-conformance-tests branch 2 times, most recently from 12878b9 to e9ed19b Compare July 19, 2021 13:06

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 19, 2021

Fetch kubevirt/kubevirtci#645 changes

f021687

Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 19, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

69ba1ac

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi mentioned this pull request Jul 19, 2021

test #1453 with kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645 kubevirt/project-infra#1458

Closed

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 20, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

3d11efb

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 20, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

e1b4c6c

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi force-pushed the sriov-lane-conformance-tests branch 2 times, most recently from d6b5ac1 to a3a712b Compare August 5, 2021 16:38

ormergi added a commit to ormergi/project-infra that referenced this pull request Aug 5, 2021

Fetch kubevirt/kubevirtci#645 changes

cb068cb

Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Aug 5, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

9cd56cd

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Aug 6, 2021

Fetch kubevirt/kubevirtci#645 changes

3806f35

Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Aug 6, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

acbd5e7

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi mentioned this pull request Aug 8, 2021

Support passing container tag/digest on Kubevirt Conformance plugin kubevirt/kubevirt#6199

Merged

ormergi force-pushed the sriov-lane-conformance-tests branch from a3a712b to 0ae3219 Compare August 9, 2021 08:09

oshoval reviewed Aug 9, 2021

View reviewed changes

ormergi force-pushed the sriov-lane-conformance-tests branch from 0ae3219 to 2e45a29 Compare August 9, 2021 10:42

ormergi requested a review from oshoval August 9, 2021 11:56

ormergi force-pushed the sriov-lane-conformance-tests branch from 0168bb5 to 8841d56 Compare August 12, 2021 13:54

oshoval approved these changes Aug 16, 2021

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021

dhiller approved these changes Sep 6, 2021

View reviewed changes

kubevirt-bot assigned dhiller Sep 6, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2021

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2021

kubevirt-bot merged commit 5a10f48 into kubevirt:main Oct 20, 2021

kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Oct 21, 2021

Bump kubevirtci

b386ebc

[5a10f48 Add check-cluster-up script for KinD providers](kubevirt/kubevirtci#645) Signed-off-by: kubevirt-bot <[email protected]>

kubevirt-bot mentioned this pull request Oct 21, 2021

Bump kubevirtci kubevirt/kubevirt#6658

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add check-cluster-up script for KinD providers #645

Add check-cluster-up script for KinD providers #645

ormergi commented Jul 18, 2021 •

edited

Loading

oshoval commented Aug 9, 2021

oshoval left a comment

oshoval Aug 9, 2021

ormergi Aug 9, 2021

oshoval Aug 9, 2021

ormergi Aug 9, 2021

oshoval Aug 10, 2021

ormergi Aug 10, 2021

ormergi commented Aug 16, 2021

oshoval commented Aug 16, 2021

ormergi commented Aug 16, 2021

oshoval left a comment

dhiller left a comment

kubevirt-bot commented Sep 6, 2021

ormergi commented Sep 9, 2021

ormergi commented Oct 19, 2021

ormergi commented Oct 19, 2021

kubevirt-commenter-bot commented Oct 19, 2021

kubevirt-commenter-bot commented Oct 20, 2021

Add check-cluster-up script for KinD providers #645

Add check-cluster-up script for KinD providers #645

Conversation

ormergi commented Jul 18, 2021 • edited Loading

oshoval commented Aug 9, 2021

oshoval left a comment

Choose a reason for hiding this comment

oshoval Aug 9, 2021

Choose a reason for hiding this comment

ormergi Aug 9, 2021

Choose a reason for hiding this comment

oshoval Aug 9, 2021

Choose a reason for hiding this comment

ormergi Aug 9, 2021

Choose a reason for hiding this comment

oshoval Aug 10, 2021

Choose a reason for hiding this comment

ormergi Aug 10, 2021

Choose a reason for hiding this comment

ormergi commented Aug 16, 2021

oshoval commented Aug 16, 2021

ormergi commented Aug 16, 2021

oshoval left a comment

Choose a reason for hiding this comment

dhiller left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Sep 6, 2021

ormergi commented Sep 9, 2021

ormergi commented Oct 19, 2021

ormergi commented Oct 19, 2021

kubevirt-commenter-bot commented Oct 19, 2021

kubevirt-commenter-bot commented Oct 20, 2021

ormergi commented Jul 18, 2021 •

edited

Loading