SRIOV provider: Deploy default CNI #644

ormergi · 2021-07-18T10:35:31Z

While back then we decided to deploy Calico CNI on KinD providers
in order to create dual-stack cluster for DEV and CI env's.

As for today we managed to enable dual-stack clusters using our
VM based providers, and eventually removed the IPV6 KinD based provider.
Though we still deploy old version of Calico on the SRIOV lane provider.

We should use the default KinD CNI 'kindnet' instead,
it will reduce complexity of the setup and maintenance.

Signed-off-by: Or Mergi [email protected]

kubevirt-bot · 2021-07-18T10:35:32Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

ormergi · 2021-07-18T10:35:57Z

/test check-up-kind-1.19-sriov

ormergi · 2021-07-18T10:37:19Z

/test check-up-kind-1.19-sriov

ormergi · 2021-07-18T13:50:32Z

/test check-up-kind-1.19-sriov

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

Test kubevirt SRIOV tests when deploying KinD default CNI plugin, 'kindnet', instead of Calico. Signed-off-by: Or Mergi <[email protected]>

ormergi · 2021-07-21T06:20:58Z

@phoracek @qinqon @maiqueb @EdDev SRIOV lane with kindnet CNI plugin pass
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/1462/rehearsal-pull-kubevirt-e2e-kind-1.19-sriov/1417481998527631360

EdDev

Very nice!

cluster-up/cluster/kind/common.sh

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi · 2021-08-10T09:18:23Z

@EdDev I addressed you review comment could you please take another look?

EdDev

Does this change mean we do not deploy dual-stack anymore on the SR-IOV lane? I could not understand that part from the commit message.

And if not, does kindnet support it (so we can add it)?

ormergi · 2021-08-10T11:30:55Z

Does this change mean we do not deploy dual-stack anymore on the SR-IOV lane? I could not understand that part from the commit message.

Yes its single stack now,
The test that checks connectivity between VM's though SRIOV interface with IPv6 is green.

And if not, does kindnet support it (so we can add it)?

In general kindnet supports dual-stack

EdDev · 2021-08-10T11:45:23Z

In general kindnet supports dual-stack

If it is easily addable, then can we do it now? It is not a must, but it will be nicer so we will not need to think about it in the future.

ormergi · 2021-08-10T13:50:54Z

If it is easily addable, then can we do it now? It is not a must, but it will be nicer so we will not need to think about it in the future.

With the new Kind API its pretty straight forward https://kind.sigs.k8s.io/docs/user/configuration/#networking
the problem is that it supported on k8s-1.20+ clusters.
Due to the fact we still use PodPreset (deprecated on k8s-1.20) we cant upgrade the provider now.
As soon as kubernetes-sigs/kind#2321 will get in we will be able to upgrade the provider,
stop using PodPreset and eventually turn on dual-stack.

EdDev

Thanks!

EdDev

ohh, what about ./cluster-up/cluster/kind/manifests/kube-calico.yaml.in?

EDIT: Also ./cluster-up/cluster/kind/manifests/kube-calico.diff.in

While back then we decided to deploy Calico CNI on KinD providers in order to create dual-stack cluster for DEV and CI env's. As for today we managed to enable dual-stack clusters using our VM based providers, and eventually removed the IPV6 KinD based provider. Though we still deploy old version of Calico on Kind infra providers. We should use the default KinD CNI 'kindnet' instead, it will reduce complexity of the setup and maintenance. Signed-off-by: Or Mergi <[email protected]>

ormergi · 2021-08-11T08:10:38Z

ohh, what about ./cluster-up/cluster/kind/manifests/kube-calico.yaml.in?

EDIT: Also ./cluster-up/cluster/kind/manifests/kube-calico.diff.in

@EdDev Done

EdDev

Thanks!

enp0s3

@ormergi Thank you!
/approve

kubevirt-bot · 2021-08-11T11:02:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [enp0s3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

``` 2c2862b cnao, Bump CNAO to 0.58.0 on all providers (kubevirt/kubevirtci#664) ba05421 cluster-provision, Prefetch cdi images (kubevirt/kubevirtci#660) 71d8ce5 Bump k8s providers (kubevirt/kubevirtci#661) 0007793 cdi, Bump cdi to 1.36.0 on k8s-1.21 (kubevirt/kubevirtci#659) 9c1261b Kind infra providers: Deploy default CNI (kubevirt/kubevirtci#644) ``` Signed-off-by: Or Shoval <[email protected]>

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 18, 2021

kubevirt-bot requested review from dhiller and rmohr July 18, 2021 10:35

kubevirt-bot added the size/XS label Jul 18, 2021

ormergi force-pushed the sriov-provider-default-cni branch from 5108c22 to 427c6ce Compare July 18, 2021 10:37

kubevirt-bot added size/S and removed size/XS labels Jul 18, 2021

kubevirt-bot added size/L and removed size/S labels Jul 18, 2021

ormergi force-pushed the sriov-provider-default-cni branch from 9a9367d to 427c6ce Compare July 18, 2021 16:07

kubevirt-bot added size/S and removed size/L labels Jul 18, 2021

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 19, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

69ba1ac

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi mentioned this pull request Jul 19, 2021

test #1453 with kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645 kubevirt/project-infra#1458

Closed

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 20, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

3d11efb

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 20, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

e1b4c6c

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Jul 20, 2021

Fetch kubevirt/kubevirtci#644 changes

21d30b2

Test kubevirt SRIOV tests when deploying KinD default CNI plugin, 'kindnet', instead of Calico. Signed-off-by: Or Mergi <[email protected]>

ormergi mentioned this pull request Jul 20, 2021

test kubevirt/kubevirtci#644 with kubevirt SRIOV lane kubevirt/project-infra#1462

Closed

EdDev reviewed Jul 21, 2021

View reviewed changes

cluster-up/cluster/kind/common.sh Show resolved Hide resolved

ormergi force-pushed the sriov-provider-default-cni branch from 427c6ce to 10ff3e6 Compare August 5, 2021 16:21

kubevirt-bot added size/M and removed size/S labels Aug 5, 2021

ormergi marked this pull request as ready for review August 5, 2021 16:22

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2021

kubevirt-bot requested a review from enp0s3 August 5, 2021 16:22

ormergi force-pushed the sriov-provider-default-cni branch from 10ff3e6 to 39b4f0e Compare August 5, 2021 16:27

ormergi added a commit to ormergi/project-infra that referenced this pull request Aug 5, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

9cd56cd

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

ormergi added a commit to ormergi/project-infra that referenced this pull request Aug 6, 2021

Fetch kubevirt/kubevirtci#644 and kubevirt/kubevirtci#645

acbd5e7

Test SRIOV provider with kindnet CNI instead of Calico and run conformance tests. Signed-off-by: Or Mergi <[email protected]>

EdDev reviewed Aug 10, 2021

View reviewed changes

EdDev approved these changes Aug 11, 2021

View reviewed changes

kubevirt-bot assigned EdDev Aug 11, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021

EdDev suggested changes Aug 11, 2021

View reviewed changes

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021

ormergi force-pushed the sriov-provider-default-cni branch from 39b4f0e to 9a80eeb Compare August 11, 2021 08:09

kubevirt-bot added size/XL and removed size/M labels Aug 11, 2021

ormergi requested a review from EdDev August 11, 2021 08:10

EdDev approved these changes Aug 11, 2021

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021

enp0s3 approved these changes Aug 11, 2021

View reviewed changes

kubevirt-bot assigned enp0s3 Aug 11, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021

kubevirt-bot merged commit 9c1261b into kubevirt:main Aug 11, 2021

enp0s3 mentioned this pull request Aug 11, 2021

remove apis being depricated in k8s 1.22 kubevirt/kubevirt#6048

Closed

ormergi mentioned this pull request Aug 11, 2021

update kube-calico from beta api to stable v1 #640

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SRIOV provider: Deploy default CNI #644

SRIOV provider: Deploy default CNI #644

ormergi commented Jul 18, 2021

kubevirt-bot commented Jul 18, 2021

ormergi commented Jul 18, 2021

ormergi commented Jul 18, 2021

ormergi commented Jul 18, 2021

ormergi commented Jul 21, 2021

EdDev left a comment

ormergi commented Aug 10, 2021

EdDev left a comment

ormergi commented Aug 10, 2021

EdDev commented Aug 10, 2021

ormergi commented Aug 10, 2021 •

edited

Loading

EdDev left a comment

EdDev left a comment •

edited

Loading

ormergi commented Aug 11, 2021

EdDev left a comment

enp0s3 left a comment

kubevirt-bot commented Aug 11, 2021

SRIOV provider: Deploy default CNI #644

SRIOV provider: Deploy default CNI #644

Conversation

ormergi commented Jul 18, 2021

kubevirt-bot commented Jul 18, 2021

ormergi commented Jul 18, 2021

ormergi commented Jul 18, 2021

ormergi commented Jul 18, 2021

ormergi commented Jul 21, 2021

EdDev left a comment

Choose a reason for hiding this comment

ormergi commented Aug 10, 2021

EdDev left a comment

Choose a reason for hiding this comment

ormergi commented Aug 10, 2021

EdDev commented Aug 10, 2021

ormergi commented Aug 10, 2021 • edited Loading

EdDev left a comment

Choose a reason for hiding this comment

EdDev left a comment • edited Loading

Choose a reason for hiding this comment

ormergi commented Aug 11, 2021

EdDev left a comment

Choose a reason for hiding this comment

enp0s3 left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Aug 11, 2021

ormergi commented Aug 10, 2021 •

edited

Loading

EdDev left a comment •

edited

Loading