Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Separate CRDs #231

Merged
merged 1 commit into from
Apr 9, 2024
Merged

✨ Separate CRDs #231

merged 1 commit into from
Apr 9, 2024

Conversation

francostellari
Copy link
Contributor

@francostellari francostellari commented Apr 3, 2024

Summary

Updated the Makefile and kustomizer to separate the CRDs of the helm from the operator.yaml

CRDs installed by an helm chart should be included in the special chart/crds/ folder to make sure that Helm installs them first, before acting on the rest of the chart.

Related issue(s)

Fixes #

Signed-off-by: francostellari <[email protected]>
@ezrasilvera
Copy link

@francostellari Can you please add couple of lines to the description about the reason to do this ?

@francostellari
Copy link
Contributor Author

@francostellari Can you please add couple of lines to the description about the reason to do this ?

@ezrasilvera I have updated the comment as you requested:

CRDs installed by an helm chart should be included in the special chart/crds/ folder to make sure that Helm installs them first, before acting on the rest of the chart.

Copy link
Collaborator

@pdettori pdettori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@francostellari
Copy link
Contributor Author

@pdettori please note that @MikeSpreitzer requested a different approach used for the status-addon: https://github.com/kubestellar/ocm-status-addon/pull/47/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
Let me know if you want me to match it here

@pdettori
Copy link
Collaborator

pdettori commented Apr 8, 2024

@pdettori please note that @MikeSpreitzer requested a different approach used for the status-addon:

@francostellari is the difference about the use of yq ? I am fine both ways, so let's leave this as it is.

@francostellari
Copy link
Contributor Author

@pdettori ok

@pdettori pdettori merged commit 8eef80c into kubestellar:main Apr 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants