Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Move CP and PCH CRDs out of operator.yaml into the special chart/crds folder #213

Closed
1 task
francostellari opened this issue Feb 21, 2024 · 3 comments

Comments

@francostellari
Copy link
Contributor

Feature Description

To ensure that CRDs are available to be sued by the chart, Helms makes user to install and wait for the avilability of the CRDs that are in the special folder chart/crds. This allows other components of the chart to install CRs.

Here is an example of error that may otherwise happen:

Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: [resource mapping not found for name: "kubestellar" namespace: "" from "": no matches for kind "PostCreateHook" in version "tenancy.kflex.kubestellar.org/v1alpha1"
ensure CRDs are installed first, resource mapping not found for name: "ocm" namespace: "" from "": no matches for kind "PostCreateHook" in version "tenancy.kflex.kubestellar.org/v1alpha1"
ensure CRDs are installed first]

Proposed Solution

Modify the make chart process to separate the CP and PCH CRDs into the special folder chart/crds

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

@pdettori
Copy link
Collaborator

I have tried this approach and it did not work as expected. I ended up using a job to install the post create hooks - see https://github.com/kubestellar/kubeflex/blob/main/chart/templates/install-hooks.yaml . But if you find a better approach that uses the crds/ dir I am all for it.

@pdettori
Copy link
Collaborator

@francostellari: this issue should have been addressed in #231. Can we close this?

@francostellari
Copy link
Contributor Author

completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants