Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve login flow #67

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: improve login flow #67

merged 1 commit into from
Dec 5, 2023

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Dec 5, 2023 •
edited
Loading

This PR fixes #66.

Changes

  • Reworked login flow. Previously, first login prompt was not awaited or checked so no matter what user pressed it was continuing the flow.
  • Added aborting of pending login requests. So if one proceeds but doesn't conclude login via browser and then runs again it will abort previous attempt (so it doesn't wait for device flow resolution).

Fixes

  • As above.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@f1ames f1ames merged commit 1592f4f into main Dec 5, 2023
3 checks passed
@f1ames f1ames deleted the f1ames/fix/66-login-flow branch December 5, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WitoDelnat WitoDelnat WitoDelnat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After cancelling login flow extension considered user being logged-in
2 participants
@f1ames @WitoDelnat