Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After cancelling login flow extension considered user being logged-in #66

Closed
f1ames opened this issue Dec 5, 2023 · 0 comments · Fixed by #67
Closed

After cancelling login flow extension considered user being logged-in #66

f1ames opened this issue Dec 5, 2023 · 0 comments · Fixed by #67
Assignees
@f1ames
Labels
bug Something isn't working

Comments

@f1ames
Copy link
Contributor

f1ames commented Dec 5, 2023

After cancelling login flow extension considers user being logged-in which leads to invalid state. User is not able to login again so one needs to run Monokle: Logout first.

It also may lead to other issues since the state is invalid (logged-in but no valid credentials or user data). And so other parts may operate based on such invalid state.
@f1ames f1ames added the bug Something isn't working label Dec 5, 2023
@f1ames f1ames self-assigned this Dec 5, 2023
@f1ames f1ames mentioned this issue Dec 5, 2023
Merged
4 tasks
@f1ames f1ames closed this as completed in #67 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f1ames f1ames

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve login flow kubeshop/vscode-monokle
1 participant
@f1ames